After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630299 - Prepare for GTK3 rendering-cleanup
Prepare for GTK3 rendering-cleanup
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-21 22:26 UTC by Garrett Regier
Modified: 2010-10-02 21:00 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
WIP - Port to rendering-cleanup (13.91 KB, patch)
2010-09-21 22:26 UTC, Garrett Regier 		none Details | Review
Port gtksourceview to GTK3 rendering changes (17.84 KB, patch)
2010-09-26 16:35 UTC, Benjamin Otte (Company) 		none Details | Review
rebased patch (17.08 KB, patch)
2010-09-27 20:42 UTC, José Aliste 		none Details | Review

Description Garrett Regier 2010-09-21 22:26:16 UTC 
Created attachment 170794 [details] [review]
WIP - Port to rendering-cleanup

This patch does not work.

I only changed the parts of the code that were pretty straight forward.

I attempted to fix it completely, however the gutter was then drawn over the textview. I removed the changes that I was unsure about so in those places it will fail to compile.
Comment 1 Ignacio Casal Quinteiro (nacho) 2010-09-22 09:15:02 UTC 
Review of attachment 170794 [details] [review]:

For what I can see so far this patch looks good to me.
Comment 2 Benjamin Otte (Company) 2010-09-26 16:35:29 UTC 
Created attachment 171131 [details] [review]
Port gtksourceview to GTK3 rendering changes
Comment 3 Paolo Borelli 2010-09-26 16:45:37 UTC 
Review of attachment 171131 [details] [review]:

Do you still get the slowdown about the current line highlighting?

The patch looks good to commit
Comment 4 José Aliste 2010-09-27 20:42:11 UTC 
Created attachment 171236 [details] [review]
rebased patch

There are some commits in git master that conflict with the previous patches. Here there is a patch rebased to current git master.
Comment 5 José Aliste 2010-09-27 21:09:19 UTC 
I pushed latest patch (as instructed in IRC). Not closing, since it seems gsv is slower after the API changes, one way of checking this is to keep the PgDown key pressed and then releasing it, it will take gsv some perceivable time to stop scrolling.
Comment 6 José Aliste 2010-10-02 21:00:27 UTC 
After aditional tests in two machines (one with ubuntu and other with fedora) I get the slowdown when scrolling even in the GtkTextView example of gtk-demo. So I think we can close this now ( I will open a new bug for TextView)