After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629534 - GLib.MissingIntPtrCtorException: GLib.Object subclass Banshee.Gui.Widgets.TaskStatusIcon
GLib.MissingIntPtrCtorException: GLib.Object subclass Banshee.Gui.Widgets.Tas...
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
1.7.5
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 629732 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-13 15:31 UTC by Chow Loong Jin
Modified: 2010-11-06 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Banshee Log (17.09 KB, text/plain)
2010-09-13 15:31 UTC, Chow Loong Jin
  Details
proposed patch (22.95 KB, patch)
2010-09-17 15:35 UTC, David Nielsen
needs-work Details | Review
Updated and tested patch (922 bytes, patch)
2010-10-15 18:49 UTC, David Nielsen
none Details | Review

Description Chow Loong Jin 2010-09-13 15:31:36 UTC
Created attachment 170164 [details]
Banshee Log

Originally reported at:
  https://bugs.launchpad.net/bugs/636953

Binary package hint: banshee

After starting Banshee it suddenly crashed after showing the main window briefly. Crash happened right after external harddrive was plugged in (and mounted), but I don't know weather that is relevant. Including the log from /home/user/.config/banshee-1.
Comment 1 Alexander Kojevnikov 2010-09-15 05:51:32 UTC
*** Bug 629732 has been marked as a duplicate of this bug. ***
Comment 2 David Nielsen 2010-09-17 15:35:05 UTC
Created attachment 170497 [details] [review]
proposed patch

This should address the issue, I know the patch isn't in the preferred git format but I am currently unable to access my development machine.
Comment 3 Bertrand Lorentz 2010-09-18 15:56:02 UTC
Review of attachment 170497 [details] [review]:

Other that its format, there's a lot of unneeded stuff in the patch.

If I just add the one line to TaskStatusIcon.cs, compilation fails :

Making all in Banshee.ThickClient
  MCS   ../../../bin/Banshee.ThickClient.dll
./Banshee.Gui.Widgets/TaskStatusIcon.cs(58,49): error CS1729: The type `Hyena.Widgets.AnimatedImage' does not contain a constructor that takes `1' arguments
Comment 4 David Nielsen 2010-10-15 18:49:21 UTC
Created attachment 172447 [details] [review]
Updated and tested patch

I apologize for the delay, here is a fixed and tested patch for the problem.
Comment 5 Alan McGovern 2010-11-05 13:18:41 UTC
The correct fix would be to figure out where is creating the TaskStatusIcon and ensure that the icon is stored in a local field on that class. That will ensure that it isn't GC'ed early which is what is happening here.

If you commit that patch you'll end up creating new managed copies of TaskStatusIcon and you'll end up with crazy issues where values set on the managed properties on that class will reset back to the defaults magically.
Comment 6 Alan McGovern 2010-11-05 13:23:54 UTC
I committed a fix for this in d986b8581d78. Let me know if it fixes the issue for you.
Comment 7 David Nielsen 2010-11-06 20:49:05 UTC
I have not been able to trigger it on git master during similar workloads as tended towards triggering it before. I am fairly certain it is gone, if it rears its ugly head again I will reopen.