After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628739 - Wrong attribute used in GIR files
Wrong attribute used in GIR files
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-09-03 21:40 UTC by Giovanni Campagna
Modified: 2015-02-07 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner: fix broken xml:whitespace attributes in .gir files (132.58 KB, patch)
2013-04-09 08:45 UTC, Dieter Verfaillie 		none Details | Review
giscanner: fix broken xml:whitespace attributes in .gir files (132.58 KB, patch)
2013-04-09 09:12 UTC, Dieter Verfaillie 		committed Details | Review

Description Giovanni Campagna 2010-09-03 21:40:37 UTC 
The doc element in GIR files has the xml:whitespace attribute set, but the correct attribute, according to the XML specification, is xml:space.
Comment 1 Bertrand Lorentz 2013-03-02 15:11:16 UTC 
For reference, the relevant part of the XML spec is:
http://www.w3.org/TR/REC-xml/#sec-white-space

This is quite annoying, because any serious attempt at validating a GIR file as correct XML will fail because of that.

I can try to come up with a patch for that, but a preliminary question is:
If this is fixed, would it have any impact on consumers of GIR files ?
Comment 2 Dieter Verfaillie 2013-04-09 08:45:46 UTC 
Created attachment 241027 [details] [review]
giscanner: fix broken xml:whitespace attributes in .gir files
Comment 3 Dieter Verfaillie 2013-04-09 09:12:11 UTC 
Created attachment 241035 [details] [review]
giscanner: fix broken xml:whitespace attributes in .gir files

Forgot to add bug link to commit message...
Comment 4 Colin Walters 2013-04-09 13:55:30 UTC 
Review of attachment 241035 [details] [review]:

The risk here to consumers is pretty low; the only thing I can think of is custom tools honoring our "xml:whitespace", but they can just update their code to check for both.
Comment 5 Dieter Verfaillie 2013-04-09 21:33:33 UTC 
Comment on attachment 241035 [details] [review]
giscanner: fix broken xml:whitespace attributes in .gir files

Committed and pushed as https://git.gnome.org/browse/gobject-introspection/commit/?id=e4b98d842ee34bf06e1afd22966ffe56885f546b
Comment 6 Dieter Verfaillie 2013-04-09 21:34:02 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 7 André Klapper 2015-02-07 16:46:28 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]