After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628676 - configure check for vala is wrong
configure check for vala is wrong
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-03 08:53 UTC by Vincent Untz
Modified: 2010-09-22 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch I'll use in openSUSE (775 bytes, patch)
2010-09-03 14:09 UTC, Vincent Untz 		rejected Details | Review

Description Vincent Untz 2010-09-03 08:53:17 UTC 
The current check for vala is:

PKG_CHECK_EXISTS([vala-1.0], [HAVE_VALA="yes"], [HAVE_VALA="no"])

However, recent versions of vala are using a 0.10 version now. Anyway, it's most likely wrong to check for the pkg-config file since it's used for the vala library, not for the compiler. Something like:

AM_PROG_VALAC([$VALA_REQUIRED])

should be used.
Comment 1 Tim-Philipp Müller 2010-09-03 09:36:21 UTC 
Not sure the VALAC check is what's needed here, but we'll figure it out, thanks :)
Comment 2 Vincent Untz 2010-09-03 14:09:18 UTC 
Created attachment 169437 [details] [review]
Patch I'll use in openSUSE

I'm using this patch in openSUSE.

But indeed, if you're just copying some files around, you might not even need any check at all.
Comment 3 Sebastian Dröge (slomo) 2010-09-22 16:13:30 UTC 
commit 6b771d391d99871ce2a9d1207f1310f3c1610a8e
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Sep 22 18:12:50 2010 +0200

    Fix configure checks and installation location for Vala bindings
    
    Fixes bug #628676.
Comment 4 Sebastian Dröge (slomo) 2010-09-22 16:13:51 UTC 
Comment on attachment 169437 [details] [review]
Patch I'll use in openSUSE

It's not necessary to check for valac here