After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628569 - Orca preferences are not getting saved permanently if a $HOME/.orca exists
Orca preferences are not getting saved permanently if a $HOME/.orca exists
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Alejandro Leiva
Orca Maintainers
Depends on:
Blocks: Andalucia 619745
 
 
Reported: 2010-09-02 00:02 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-09-20 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for bgo 628569 (2.09 KB, patch)
2010-09-13 10:23 UTC, Alejandro Leiva
accepted-commit_now Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-09-02 00:02:19 UTC
From Steve on the Orca List:

~~~~~~~~~~~~
I did have one hitch I had to get around with this latest change.  It
seems that if the old settings are still available in .orca, they keep
getting copied over to .local/share/orca each time Orca is restarted.
Let me give a sequence I ran through thisevening.

1. Get into orca and go into the preferences dialog; change something
that can be tracked and easily verified like the show main window
checkbox.  Change this.

2. Quit Orca or do a --replace to make it restart.

3. Notice that when Orca restarted, the change does not take effect.

While observing this repeadedly, I decided to peak around in the
.local/share/orca/user-settings.py at the showMainWindow item.  When I
applied the orca settings or closed the preferences window with OK, I
looked into the settings.py file and saw that the option was indeed
set to true from the original value of false.  Upon restarting Orca,
this file apparently got overwritten because this value went back to
false.  This happened to me a couple times so I then went and renamed
.orca to something else and then went through the 3 steps outlined
above and the value sticks now.  So I think .orca is being copied
every time Orca restarts.
Comment 1 Alejandro Leiva 2010-09-13 10:23:12 UTC
Created attachment 170130 [details] [review]
Fix for bgo 628569

Added a new patch to fix this issue.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-09-13 11:46:54 UTC
Review of attachment 170130 [details] [review]:

LGTM. I also like how you are only copying what needs to be copied over so that removing user-settings.py doesn't cause one to lose all of the app settings.

Please commit to master. Thanks!
Comment 4 Thomas REIS 2010-09-13 17:53:00 UTC
I was away for the summer and just came back, and decided to pull from git to get the latest orca.
I  entered in the command line : ./autogen.ssh ; make ; sudo make install and then launched orca and got the following error:

Traceback (most recent call last):
  • File "<string>", line 1 in <module>
  • File "/usr/local/lib/python2.6/dist-packages/orca/orca.py", line 2183 in main
    shutil.copy(srcFile, dstFile)
  • File "/usr/lib/python2.6/shutil.py", line 88 in copy
    copyfile(src, dst)
  • File "/usr/lib/python2.6/shutil.py", line 53 in copyfile
    fdst = open(dst, 'wb')
IOError: [Errno 2] No such file or directory: '/home/tr258/.local/share/orca/.orca1/orca-scripts/__init__.pyc'
[t8@R8:0:~]$: cd .local/share/orca/.orca1/orca-scripts
bash: cd: .local/share/orca/.orca1/orca-scripts: No such file or directory

with Jon, i have found that if i use any commit before 1f5093 every thing works fine.

cheers Tom
Comment 5 Alejandro Leiva 2010-09-13 18:48:27 UTC
Hi thomas, please can you add to the bug a full 'ls -la' of your ~/.orca and ~/.local/share/orca ?

Cheers!
Comment 6 Thomas REIS 2010-09-13 19:05:12 UTC
Hi Alejendro, here is what you asked me.
hope this helps!

[t8@R8:0:~/.orca]$: ls -la
total 36
drwxr-xr-x  5 tr258 tr258 4096 2010-09-13 17:42 .
drwxr-xr-x 57 tr258 tr258 4096 2010-09-13 17:40 ..
drwxr-xr-x  2 tr258 tr258 4096 2010-06-14 00:34 app-settings
drwxr-xr-x  4 tr258 tr258 4096 2010-06-13 23:12 .orca1
drwxr-xr-x  2 tr258 tr258 4096 2010-06-14 00:34 orca-scripts
-rw-r--r--  1 tr258 tr258 7781 2010-09-13 17:42 user-settings.py
-rw-r--r--  1 tr258 tr258 6598 2010-09-13 17:42 user-settings.pyc


[t8@R8:0:~/.local/share/orca]$: ls -la
total 36
drwxr-xr-x  5 tr258 tr258 4096 2010-09-13 18:44 .
drwx------ 19 tr258 tr258 4096 2010-09-13 18:26 ..
drwxr-xr-x  2 tr258 tr258 4096 2010-09-13 18:26 app-settings
drwxr-xr-x  2 tr258 tr258 4096 2010-09-13 18:26 .orca1
drwxr-xr-x  2 tr258 tr258 4096 2010-09-13 18:26 orca-scripts
-rw-r--r--  1 tr258 tr258 7781 2010-09-13 18:44 user-settings.py
-rw-r--r--  1 tr258 tr258 6622 2010-09-13 18:44 user-settings.pyc

cheers 
Tom
Comment 7 Alejandro Leiva 2010-09-13 19:42:45 UTC
Thanks Tom!

Now it's fixed. Please test it.

Commited at http://git.gnome.org/browse/orca/commit/?id=a48205b7d930380b6d44fef4a60284a44087251c
Comment 8 Thomas REIS 2010-09-13 20:48:20 UTC
Hi Alenjendro, 

It works just fine now,
thank you very much for your quick fix
cheers

Tom