After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628499 - Make gnome-utils future-safe
Make gnome-utils future-safe
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks: 626688
 
 
Reported: 2010-09-01 12:15 UTC by Benjamin Otte (Company)
Modified: 2010-09-01 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot: Fix compiler warnings (2.62 KB, patch)
2010-09-01 12:15 UTC, Benjamin Otte (Company) 		none Details | Review
gsearchtool: Use gtk_widget_set_can_default() (4.65 KB, patch)
2010-09-01 12:15 UTC, Benjamin Otte (Company) 		none Details | Review
logview: Use gtk_widget_set_can_focus (1.57 KB, patch)
2010-09-01 12:15 UTC, Benjamin Otte (Company) 		none Details | Review
screenshot: Draw preview widget with Cairo (1.55 KB, patch)
2010-09-01 12:15 UTC, Benjamin Otte (Company) 		none Details | Review
screenshot: Don't draw directly to the root window (8.80 KB, patch)
2010-09-01 12:16 UTC, Benjamin Otte (Company) 		none Details | Review
baobab: Fix compiler warnings from -Wall (7.53 KB, patch)
2010-09-01 12:16 UTC, Benjamin Otte (Company) 		none Details | Review
gdict: Fix compiler warnings from -Wall (6.01 KB, patch)
2010-09-01 12:16 UTC, Benjamin Otte (Company) 		none Details | Review

Description Benjamin Otte (Company) 2010-09-01 12:15:45 UTC 
Here's a set of patches that make gnome-utils work with "-DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -Wall -Werror". The only complex change is making the screenshot area code use a GtkWindow instead of scribbling all over the root window.
Comment 1 Benjamin Otte (Company) 2010-09-01 12:15:47 UTC 
Created attachment 169237 [details] [review]
screenshot: Fix compiler warnings
Comment 2 Benjamin Otte (Company) 2010-09-01 12:15:52 UTC 
Created attachment 169238 [details] [review]
gsearchtool: Use gtk_widget_set_can_default()

Replaces previous usage of GTK_WIDGET_SET_FLAGS() and makes code
sealing-safe.
Comment 3 Benjamin Otte (Company) 2010-09-01 12:15:56 UTC 
Created attachment 169239 [details] [review]
logview: Use gtk_widget_set_can_focus

Replaces previous usage of GTK_WIDGET_SET_FLAGS() and makes code
sealing-safe.
Comment 4 Benjamin Otte (Company) 2010-09-01 12:15:59 UTC 
Created attachment 169240 [details] [review]
screenshot: Draw preview widget with Cairo
Comment 5 Benjamin Otte (Company) 2010-09-01 12:16:03 UTC 
Created attachment 169241 [details] [review]
screenshot: Don't draw directly to the root window

Instead, create a GtkWindow to draw the selected area with. As a side
effect, the selected area looks much nicer and not like 1995 anymore.
Also, the code doesn't use deprecated APIs anymore.
Comment 6 Benjamin Otte (Company) 2010-09-01 12:16:06 UTC 
Created attachment 169242 [details] [review]
baobab: Fix compiler warnings from -Wall

Seriously, people...
Comment 7 Benjamin Otte (Company) 2010-09-01 12:16:09 UTC 
Created attachment 169243 [details] [review]
gdict: Fix compiler warnings from -Wall
Comment 8 Emmanuele Bassi (:ebassi) 2010-09-01 12:37:35 UTC 
feel free to commit them all - they all look sane to me.
Comment 9 Benjamin Otte (Company) 2010-09-01 12:58:29 UTC 
Pushed them all.
And I was free to add another patch that cleans up -Wall for the logviewer.