GNOME Bugzilla – Bug 628326
vdpau: don't change structure in setcaps function
Last modified: 2010-09-06 10:38:05 UTC
It's not allowed (and not needed) to change the caps (via the structure) provided by the setcaps function.
Created attachment 169057 [details] [review] vdpau: don't change structure in setcaps function
Aren't the structure changes needed to set the source pad to double framerate progressive video if input is interlaced and deinterlacing is enabled? I think video_caps (which is accessed through the structure) should be a copy of caps, not a reference to it. Replacing gst_caps_ref() with gst_caps_copy() on line 496 seems to work for me. Is this correct?
I've commited a slightly different fix which is keeping the framerate doubling.
> I've commited a slightly different fix which is keeping the framerate doubling. Have you pushed that yet? If yes, what commit was it?
Just pushed it as b2ce3aab96f924c4d7f5fcbdad2a78682f4ce4ee.
commit b2ce3aab96f924c4d7f5fcbdad2a78682f4ce4ee Author: Carl-Anton Ingmarsson <ca.ingmarsson@gmail.com> Date: Sun Sep 5 16:30:05 2010 +0200 vdpauvideopostprocess: set new framerate on output caps instead of input caps It's not allowed to change the caps provided by the setcaps function. https://bugzilla.gnome.org/show_bug.cgi?id=628326