After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627601 - Memory leak in itip_get_comp_attendee()
Memory leak in itip_get_comp_attendee()
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks: 627707
 
 
Reported: 2010-08-21 21:51 UTC by David Woodhouse
Modified: 2013-09-13 01:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.27 KB, patch)
2010-08-21 22:24 UTC, David Woodhouse
committed Details | Review

Description David Woodhouse 2010-08-21 21:51:46 UTC
==24539== 26 bytes in 1 blocks are definitely lost in loss record 8,702 of 27,015
==24539==    at 0x4A0515D: malloc (vg_replace_malloc.c:195)
==24539==    by 0x3A4DC45784: g_malloc (in /lib64/libglib-2.0.so.0.2512.0)
==24539==    by 0x3A4DC5D2DD: g_strdup (in /lib64/libglib-2.0.so.0.2512.0)
==24539==    by 0xEC76D78: itip_get_comp_attendee (itip-utils.c:252)
==24539==    by 0x16F34E5C: format_itip_object (itip-formatter.c:1707)
==24539==    by 0xF15A218: efh_object_requested (em-format-html.c:1560)
==24539==    by 0x7039397: html_g_cclosure_marshal_BOOLEAN__OBJECT (htmlmarshal.c:81)
==24539==    by 0x3A4E40D7BD: g_closure_invoke (in /lib64/libgobject-2.0.so.0.2512.0)
==24539==    by 0x3A4E425D68: ??? (in /lib64/libgobject-2.0.so.0.2512.0)
==24539==    by 0x3A4E42730B: g_signal_emit_valist (in /lib64/libgobject-2.0.so.0.2512.0)
==24539==    by 0x3A4E427D22: g_signal_emit (in /lib64/libgobject-2.0.so.0.2512.0)
==24539==    by 0x6FF664D: html_engine_object_requested_cb (gtkhtml.c:549)
Comment 1 David Woodhouse 2010-08-21 22:24:17 UTC
Created attachment 168480 [details] [review]
patch
Comment 2 David Woodhouse 2010-08-22 00:25:02 UTC
And a related one:
==23683== 1 bytes in 1 blocks are definitely lost in loss record 69 of 26,937
==23683==    at 0x4A0515D: malloc (vg_replace_malloc.c:195)
==23683==    by 0x3A4DC45784: g_malloc (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x3A4DC5D2DD: g_strdup (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x3A4DC75721: ??? (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x3A4DC75481: ??? (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x3A4DC75C48: g_variant_get_va (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x3A4DC75E85: g_variant_get (in /lib64/libglib-2.0.so.0.2512.0)
==23683==    by 0x6DA697F: e_gdbus_cal_call_get_cal_address_sync (e-gdbus-egdbuscal.c:2050)
==23683==    by 0x6D8C374: e_cal_get_cal_address (e-cal.c:1625)
==23683==    by 0xEC76CE7: itip_get_comp_attendee (itip-utils.c:205)
==23683==    by 0xEC99827: event_editor_edit_comp (event-editor.c:634)
==23683==    by 0xEC27585: e_calendar_view_open_event_with_flags (e-calendar-view.c:1550)

Same error in event-editor.c::event_editor_edit_comp():
--- a/calendar/gui/dialogs/event-editor.c
+++ b/calendar/gui/dialogs/event-editor.c
@@ -696,6 +696,7 @@ event_editor_edit_comp (CompEditor *editor, ECalComponent *comp)
 
                event_page_set_meeting (priv->event_page, TRUE);
                priv->meeting_shown = TRUE;
+               g_free (user_email);
        }
        e_cal_component_free_attendee_list (attendees);
 

There are other calls to itip_get_comp_attendee() which probably want auditing.
Comment 3 David Woodhouse 2010-08-24 00:13:55 UTC
To ssh://dwmw2@git.gnome.org/git/evolution
   3116748..7a2e06e  master -> master

Leaving it open; that audit still needs doing.
Comment 4 David Woodhouse 2010-08-24 00:18:02 UTC
Oh, and the patch from comment 1, too:

To ssh://dwmw2@git.gnome.org/git/evolution
   480b9e1..336000a  master -> master
Comment 5 Chenthill P 2010-08-30 08:33:22 UTC
comment #2 should be fixed with the fix for bug 627617 . I guess this can be closed ?
Comment 6 Milan Crha 2010-09-06 13:27:25 UTC
Both are committed, closing.