After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627328 - GIMP 2.6.10 segfaults when CTRL-left click on a layer mask
GIMP 2.6.10 segfaults when CTRL-left click on a layer mask
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.6.10
Other All
: High critical
: 2.6
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2010-08-19 02:19 UTC by Luis A. Florit
Modified: 2010-10-10 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for the bug. (1.37 KB, patch)
2010-10-10 18:40 UTC, bugreporting
committed Details | Review

Description Luis A. Florit 2010-08-19 02:19:49 UTC
Since 2.6.7 or 2.6.8 I am having a persistent crash with GIMP:
When CTRL-left clicking on a layer mask to toggle it, about 30% of the times my GIMP segfaults and badly crashes. Last time this happens I got this:

Aug 18 22:59:18 Orion kernel: gimp-2.6[12503]: segfault at 24 ip 0820f90e sp bff3b410 error 4 in gimp-2.6[8045000+4a2000]

Any clues?

Thanks,
L.
Comment 1 Akhil Laddha 2010-08-19 03:42:05 UTC
Thanks for taking the time to report this bug.
Without a stack trace from the crash it's very hard to determine what caused it.
Can you get us a stack trace? Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!

If you can reproduce it while running
under gdb (see http://live.gnome.org/GettingTraces/Details#gdb-not-yet-running for details about how to do this), that might help getting a better trace if you've already got debug packages installed.
Comment 2 Luis A. Florit 2010-08-27 21:10:19 UTC
(In reply to comment #1)
> Thanks for taking the time to report this bug.
> Without a stack trace from the crash it's very hard to determine what caused
> it.
> Can you get us a stack trace? Please see http://live.gnome.org/GettingTraces
> for more information on how to do so. Thanks in advance!
> 
> If you can reproduce it while running
> under gdb (see http://live.gnome.org/GettingTraces/Details#gdb-not-yet-running
> for details about how to do this), that might help getting a better trace if
> you've already got debug packages installed.

Sorry for the delay...

I installed a bunch of debug packages, and GIMP crashed again with a control-left-click on a layer mask after a long work. This is what I got (not sure if this will be usefull):

[New Thread 16662]
[New Thread 16664]
[New Thread 16663]
[New Thread 16665]
[New Thread 16666]
Core was generated by `gimp --display :0.0 file:///home/gato/.tmp/ovni10_REGUA-100824-O_51224.tif'.
Program terminated with signal 11, Segmentation fault.

Thread 1 (Thread 16662)

  • #0 gimp_cell_renderer_viewable_clicked
    at gimpcellrendererviewable.c line 336
  • #1 gimp_container_tree_view_button_press
    at gimpcontainertreeview.c line 1061
  • #2 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #3 IA__g_closure_invoke
    at gclosure.c line 767
  • #4 signal_emit_unlocked_R
    at gsignal.c line 3248
  • #5 IA__g_signal_emit_valist
    at gsignal.c line 2991
  • #6 IA__g_signal_emit
    at gsignal.c line 3038
  • #7 gtk_widget_event_internal
    at gtkwidget.c line 4958
  • #8 IA__gtk_propagate_event
    at gtkmain.c line 2442
  • #9 IA__gtk_main_do_event
    at gtkmain.c line 1608
  • #10 gdk_event_dispatch
    at gdkevents-x11.c line 2372
  • #11 g_main_dispatch
    at gmain.c line 1960
  • #12 IA__g_main_context_dispatch
    at gmain.c line 2513
  • #13 g_main_context_iterate
    at gmain.c line 2591
  • #14 IA__g_main_loop_run
    at gmain.c line 2799
  • #15 app_run
    at app.c line 246
  • #16 main
    at main.c line 406

Comment 3 Martin Nordholts 2010-08-28 05:22:55 UTC
Are you sure you are running GIMP 2.6.10? I suspect this is a duplicate to bug 622608 which was fixed in that version.
Comment 4 Michael Natterer 2010-08-30 18:16:07 UTC
I can reproduce that, using a test file and sessionrc somebody
dropped in IRC. Barak is about to attach a minimal test case.
Comment 5 LightningIsMyName 2010-08-30 19:34:39 UTC
This took lots of research to find the exact step which triggers the crash, but here it is...

1. Create/Open an image with a layer that has a mask
2. Switch from the layers tab that it won't be visible (I only managed to reproduce when the layers dialog was tabbed with some other docks)
3. Switch back to the layers tab and make sure you DO NOT click on the layer with the mask.
4. Alt+Click / Ctrl+Click the mask
5. Watch GIMP crash

If after step 3, you click on the layer in the layers dialog, the crash won't happen.
Comment 6 Luis A. Florit 2010-09-08 01:41:33 UTC
(In reply to comment #3)
> Are you sure you are running GIMP 2.6.10? I suspect this is a duplicate to bug
> 622608 which was fixed in that version.

$ rpm -q gimp
gimp-2.6.10-1.fc13.i686

I am having the very same problem in two computers with identical FC13 packages.

L.
Comment 7 bugreporting 2010-10-10 18:40:11 UTC
Created attachment 172059 [details] [review]
Patch for the bug.
Comment 8 Michael Natterer 2010-10-10 20:36:54 UTC
Thanks, fixed in both branches:

commit b23d1635cd435790bffcf50bbff5753d34c9ff97
Author: Christian Krippendorf <Kontakt-Programming@CerebrosuS.de>
Date:   Sun Oct 10 22:31:35 2010 +0200

    Bug 627328 - GIMP 2.6.10 segfaults when CTRL-left click on a layer mask
    
    Move the g_signal_emit() to the end, because the cell->renderer could
    be changed and cause a segfault. Also check cell->renderer before
    dereferencing it.
    (cherry picked from commit ff03681bdfa371891ec7cc754bfed811c5c434e6)