After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627268 - [tag] add GST_TAG_ENCODED_BY and map id3v2 TENC frame
[tag] add GST_TAG_ENCODED_BY and map id3v2 TENC frame
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-18 15:03 UTC by sreerenj
Modified: 2011-02-01 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a new "encoded by" tag (1.65 KB, patch)
2010-08-19 19:57 UTC, sreerenj
committed Details | Review
Map the "Encoded by" frame(TENC) of id3v2 to GST_TAG_ENCODED_BY (815 bytes, patch)
2010-08-19 19:58 UTC, sreerenj
committed Details | Review

Description sreerenj 2010-08-18 15:03:33 UTC
The "encoded by" frame of id3v2 can be add as GST_TAG_ORGANIZATION tag of gstreamer.
Comment 1 Sebastian Dröge (slomo) 2010-08-19 15:58:00 UTC
  TENC
   The 'Encoded by' frame contains the name of the person or
   organisation that encoded the audio file. This field may contain a
   copyright message, if the audio file also is copyrighted by the
   encoder.

I don't think that's the same meaning as GST_TAG_ORGANIZATION.
Comment 2 sreerenj 2010-08-19 18:22:26 UTC
yup :) I too had a doubt regarding that. Anyway I will add it as separate "Encoded by " tag.
Comment 3 sreerenj 2010-08-19 19:57:44 UTC
Created attachment 168316 [details] [review]
Add a new "encoded by" tag
Comment 4 sreerenj 2010-08-19 19:58:53 UTC
Created attachment 168318 [details] [review]
Map the "Encoded by" frame(TENC) of id3v2 to GST_TAG_ENCODED_BY
Comment 5 sreerenj 2010-08-19 20:12:11 UTC
(In reply to comment #1)
>   TENC
>    The 'Encoded by' frame contains the name of the person or
>    organisation that encoded the audio file. This field may contain a
>    copyright message, if the audio file also is copyrighted by the
>    encoder.
> 
> I don't think that's the same meaning as GST_TAG_ORGANIZATION.

Sebastian, sorry for the corruption.
Comment 6 sreerenj 2010-09-07 07:45:36 UTC
Hi, Any comments ?
Comment 7 Tim-Philipp Müller 2011-02-01 14:30:31 UTC
Fixed some style/indentation issues, added new tag to docs, and fixed up commit messages a bit.

Thanks for the patches!

commit de55965ebeb48fabc67ec95256a9e3521b396312
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Thu Aug 19 22:43:07 2010 +0300

    taglist: add a new "encoded-by" tag
    
    Usecase: ID3v2 TENC ("Encoded by") frame.
    
    API: GST_TAG_ENCODED_BY
    
    https://bugzilla.gnome.org/show_bug.cgi?id=627268

commit c36a3e46f5151d6f8b0c723f9e12d1f19fcca4b5
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Thu Aug 19 22:31:07 2010 +0300

    id3tag: map the ID3v2 TENC frame to GST_TAG_ENCODED_BY
    
    https://bugzilla.gnome.org/show_bug.cgi?id=627268