After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627162 - [pulse] better fallback return value for gst_pulse_client_name()
[pulse] better fallback return value for gst_pulse_client_name()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-17 14:22 UTC by Philippe Normand
Modified: 2010-09-04 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pulseutil: include pid value in gst_pulse_client_name() fallback return value (1.17 KB, patch)
2010-08-17 14:28 UTC, Philippe Normand 		needs-work Details | Review
pulseutil: include pid value in gst_pulse_client_name() fallback return value (2.22 KB, patch)
2010-08-17 15:03 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2010-08-17 14:22:47 UTC 
Currently the gst_pulse_client_name() fallbacks to return "GStreamer". We should add the application pid value.
Comment 1 Philippe Normand 2010-08-17 14:28:33 UTC 
Created attachment 168085 [details] [review]
pulseutil: include pid value in gst_pulse_client_name() fallback return value

Fixes bug 627162
Comment 2 Sebastian Dröge (slomo) 2010-08-17 14:37:18 UTC 
Comment on attachment 168085 [details] [review]
pulseutil: include pid value in gst_pulse_client_name() fallback return value

There's nothing in configure to check for process.h, other than that this is good
Comment 3 Philippe Normand 2010-08-17 15:03:06 UTC 
Created attachment 168093 [details] [review]
pulseutil: include pid value in gst_pulse_client_name() fallback return value

Fixes bug 627162
Comment 4 Sebastian Dröge (slomo) 2010-08-19 10:40:23 UTC 
Ok, will push this after release. Thanks :)
Comment 5 Sebastian Dröge (slomo) 2010-09-04 13:13:58 UTC 
commit 39d2ef5136a7c50458567a9be643bfcaaccfdff5
Author: Philippe Normand <pnormand@igalia.com>
Date:   Tue Aug 17 16:26:41 2010 +0200

    pulseutil: include pid value in gst_pulse_client_name() fallback return val
    
    Fixes bug #627162