Created attachment 168418 [details] [review]
background panel GSettings port

Port of the background panel to GSettings and new gnome-bg API - bug 626021. I haven't tested the Flickr backend, please also test overall functionality to avoid regressions.

Works fine in conjuction with nautilus patch from bug 626018. In case of nautilus absence I guess gnome-settings-daemon should take over the rendering job, this needs to be ported yet though.

Setting as 'needs-work' for the moment until we sort new gnome-desktop api out.

Created attachment 170678 [details] [review]
background panel GSettings port

Updated patch to reflect gnome-bg changes from bug 626021. Not much changed except of the way settings is pulled and saved from/to GnomeBg, moved chunks of code in gnome-wp-item.c, all this to prevent NULL or uninitialized values after initial GnomeBg instance creation.

We still need the gnome-bg changes to be accepted to apply this, right?

(In reply to comment #3)
> We still need the gnome-bg changes to be accepted to apply this, right?
Yes, that's right. We're polishing last few details there...

(In reply to comment #3)
> We still need the gnome-bg changes to be accepted to apply this, right?
Hmm, okay, looks like my work here became useless due to four commits done in master.

(In reply to comment #5)
> (In reply to comment #3)
> > We still need the gnome-bg changes to be accepted to apply this, right?
> Hmm, okay, looks like my work here became useless due to four commits done in
> master.

What changes are we talking about?

Created attachment 173832 [details] [review]
Fix last usage of old gnome-bg API

So this simple patch is all that's needed for control-center to work with new gnome-bg API.

Still, the code in gnome-wp-item.c uses GSettings directly. This is not bad but in near time horizon we would like to change that and use gnome-bg directly. My previous patch did that though it required GnomeBg object to live and did extensive shuffling of initialization. Let's keep this in mind and when time allows, I may post another patch here.

Review of attachment 173832 [details] [review]:

Great to see that's all we need! So please commit.

Reopen as this is still in the configure.ac:

PKG_CHECK_MODULES(LIBGNOME_CONTROL_CENTER, $COMMON_MODULES gconf-2.0)

(In reply to comment #9)
> Reopen as this is still in the configure.ac:
> 
> PKG_CHECK_MODULES(LIBGNOME_CONTROL_CENTER, $COMMON_MODULES gconf-2.0)

It's waiting on metacity/mutter being ported to GSettings.

Ok Bastian, adding metacity bug dependency

Created attachment 201203 [details] [review]
keyboard: Port custom shortcuts to GSettings

commit bc6d4b3cf15beeb580757786b71f4333afe6bb42
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Nov 14 14:29:31 2011 +0000

    universal-access: Remove unused GConf helper

commit 957374dfa90c6626bdd0df945fd680d31cafbe21
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Nov 14 14:27:40 2011 +0000

    universal-access: Update for metacity GSettings port
    
    Use GSettings to set the visual-bell preferences, rather than GConf.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=625899

Attachment 201203 [details] pushed as 656d0ee - keyboard: Port custom shortcuts to GSettings