GNOME Bugzilla – Bug 625502
Notification layout is sometimes wrong when updating
Last modified: 2010-09-04 02:29:27 UTC
When updating a notification that is already shown (for example because a new chat message is received, but could happen also with libnotify and replaces-id), the banner and title are recreated instead that just updated, so they don't get the opacity of the previous banner (hidden if the notification is shown). This means: - for new notifications (in the middle of screen): banner flickers - for summary notifications: banner is not hidden as it should be
Created attachment 166721 [details] [review] Reuse same labels and containers on notification updates When calling Notification.update, reuse the previous _bannerBox and related labels (only changing the label content and relayouting), so that the opacity set on popOut is preserved. As a consequence, updating an opened notification no longer shows (or flicker) the banner at the top.
Created attachment 166725 [details] [review] Reuse same labels and containers on notification updates Removed setting clearing opacity on bannerLabel when relayouting bannerBox. This regresses on the opposite side: updating from a long notification to a short (single line) one, the banner is kept hidden; that feature is broken anyway, as the notification is kept floating at the previous y.
Comment on attachment 166725 [details] [review] Reuse same labels and containers on notification updates looks good. can you file another bug (or update the summary of this one) for the height/visibility issues on update?
Summary changed. The bug description is simple (assuming the pushing of the patch and the related regression): updating an open notification won't show the summary, even if it is short, and will leave the notification floating in the air
Comment on attachment 166725 [details] [review] Reuse same labels and containers on notification updates Attachment 166725 [details] pushed as 4e283cf - Reuse same labels and containers on notification updates
https://bugzilla.gnome.org/show_bug.cgi?id=617209#c18 re-works how we update expanded notifications and fixes the problems described here. *** This bug has been marked as a duplicate of bug 617209 ***