GNOME Bugzilla – Bug 624922
Read-Only collection sync
Last modified: 2020-03-17 08:50:03 UTC
Created attachment 166280 [details] [review] implementation I use a smart-playlist, watching a folder to determine which files to sync to my DAP. However upon deletion of these files locally, Banshee wants to delete them from my DAP. Which is not my intent. Attached patch 1.) Introduces a Read-Only setting in the DAP Config Pane 2.) Changes the dialog, which is triggered by MAX_NOWARN_TRACKS_REMOVAL, to add a "Sync Read-Only" button. what is missing in 2.) is a checkbox to remember that choice. Perhaps someone else finds that useful :)
Hey, your idea seems interesting but I'm not sure it should be implemented as a sub-preference of AutoSync, because if you're not syncing the deletion of files, it's not AutoSync anymore. If you did it this way (adding a 3rd option besides ManualSync and AutoSync) you wouldn't need to mess up with the dialog that brings up the PossibleUserErrorException use case. Anyway I believe this should be discussed with more banshee developers to be approved. The rest of the patch looks good except for the fact that you're missing some style nits, like 4spaces instead of tabs (please read HACKING). Thanks
Hi, thx for your feedback. I once changed the selector on the preference pane to display "Copy", which resulted in Sync from "playlist1" Copy from "playlist1" Sync from "playlist2" Copy from "playlist2" * which looked clumsy. Or did I misunderstand "sub-preference of AutoSync"? The dialog saved my collection from being deleted, which provided my hacking starting point, this change is however not needed. I will reformat and split into two patches, if consensus is reached ;)
Comment on attachment 166280 [details] [review] implementation (In reply to comment #2) > which looked clumsy. Or did I misunderstand "sub-preference of AutoSync"? Makes sense. Then it's ok by me, but you still the sign-off from a maintainer. > ...this change is however not needed. I will reformat and split > into two patches, if consensus is reached ;) Ok cool, marking this patch then as needs-work. Thanks for your effort. Looking forward to next patch.
s/still/still need/
Created attachment 166342 [details] [review] Add Read-Only Library Syncing
Created attachment 166343 [details] [review] Falback to Read-Only Sync panic button
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.