After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624901 - Terminal plugin doesn't build with latest vte
Terminal plugin doesn't build with latest vte
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: terminal
git master
Other Linux
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-21 06:58 UTC by Frederic Peters
Modified: 2010-07-21 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use accessor to get terminal widget adjustment (692 bytes, patch)
2010-07-21 06:59 UTC, Frederic Peters 		accepted-commit_now Details | Review

Description Frederic Peters 2010-07-21 06:58:33 UTC 
http://build.gnome.org/builders/anjuta-bxlug-sid/builds/1385/steps/anjuta%20build/logs/stdio

  CC     terminal.lo
terminal.c: In function 'terminal_execute':
terminal.c:405: warning: 'vte_terminal_fork_command' is deprecated (declared at /home/jhbuild/sid-ia32/build/include/vte-0.0/vte/vtedeprecated.h:82)
terminal.c: In function 'init_shell':
terminal.c:466: warning: 'vte_terminal_fork_command' is deprecated (declared at /home/jhbuild/sid-ia32/build/include/vte-0.0/vte/vtedeprecated.h:82)
terminal.c: In function 'create_box':
terminal.c:712: error: 'VteTerminal' has no member named 'adjustment'
make[3]: *** [terminal.lo] Error 1

Attached patch use an accessor function to get the adjustment widget, doesn't touch vte_terminal_fork_command'. I also checked when that function was introduced and it's 2002, so there's no need to update configure.ac.
Comment 1 Frederic Peters 2010-07-21 06:59:07 UTC 
Created attachment 166257 [details] [review]
use accessor to get terminal widget adjustment
Comment 2 Johannes Schmid 2010-07-21 07:09:37 UTC 
Review of attachment 166257 [details] [review]:

Thanks. If I understood you correct the get_adjustment() method has been there for quite some time so please commit!
Comment 3 Frederic Peters 2010-07-21 08:10:53 UTC 
Thanks, pushed as 9069d1.