After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624834 - Remove deprecated sink functions
Remove deprecated sink functions
Status: RESOLVED FIXED
Product: pygtk
Classification: Bindings
Component: gtk
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-20 14:16 UTC by Colin Walters
Modified: 2010-08-07 22:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove deprecated sink functions (929 bytes, patch)
2010-07-20 14:17 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2010-07-20 14:16:58 UTC
This is handled automatically now; see commit 00a85f6a844714d1 in pygobject.
Comment 1 Colin Walters 2010-07-20 14:17:00 UTC
Created attachment 166208 [details] [review]
Remove deprecated sink functions
Comment 2 johnp 2010-07-30 08:39:14 UTC
Comment on attachment 166208 [details] [review]
Remove deprecated sink functions

Commit away
Comment 3 Colin Walters 2010-07-30 14:19:44 UTC
Attachment 166208 [details] pushed as 0d78815 - Remove deprecated sink functions
Comment 4 John Stowers 2010-08-07 05:43:45 UTC
I get many test failures in pygtk with this applied and built against pygobject-2.21.3 (or later).

$ python runtests.py test_bin.py
Gtk-Message: Failed to load module "canberra-gtk-module": libcanberra-gtk-module.so: cannot open shared object file: No such file or directory

Gtk-WARNING **: A floating object was finalized. This means that someone
called g_object_unref() on an object that had only a floating
reference; the initial floating reference is not owned by anyone
and must be removed with g_object_ref_sink().
aborting...
Trace/breakpoint trap


Thoughts?
Comment 5 Tomeu Vizoso 2010-08-07 15:33:56 UTC
(In reply to comment #4)
> I get many test failures in pygtk with this applied and built against
> pygobject-2.21.3 (or later).
> 
> $ python runtests.py test_bin.py
> Gtk-Message: Failed to load module "canberra-gtk-module":
> libcanberra-gtk-module.so: cannot open shared object file: No such file or
> directory
> 
> Gtk-WARNING **: A floating object was finalized. This means that someone
> called g_object_unref() on an object that had only a floating
> reference; the initial floating reference is not owned by anyone
> and must be removed with g_object_ref_sink().
> aborting...
> Trace/breakpoint trap
> 
> 
> Thoughts?

I would have expected these failures only in pygobject-2.21.3.

Tests pass here, can you check you are using a recent enough PyGObject?
Comment 6 John Stowers 2010-08-07 22:45:24 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > I get many test failures in pygtk with this applied and built against
> > pygobject-2.21.3 (or later).
> > 
> > $ python runtests.py test_bin.py
> > Gtk-Message: Failed to load module "canberra-gtk-module":
> > libcanberra-gtk-module.so: cannot open shared object file: No such file or
> > directory
> > 
> > Gtk-WARNING **: A floating object was finalized. This means that someone
> > called g_object_unref() on an object that had only a floating
> > reference; the initial floating reference is not owned by anyone
> > and must be removed with g_object_ref_sink().
> > aborting...
> > Trace/breakpoint trap
> > 
> > 
> > Thoughts?
> 
> I would have expected these failures only in pygobject-2.21.3.
> 
> Tests pass here, can you check you are using a recent enough PyGObject?

Yeah, I was off by one version. Apologies