After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624772 - vapigen needs to handle GIR's switch from attribute to child tag doc strings
vapigen needs to handle GIR's switch from attribute to child tag doc strings
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Code Generator
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 619703 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-19 21:58 UTC by Travis Reitter
Modified: 2010-07-27 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Completely ignore <doc> tags in GIR files (802 bytes, patch)
2010-07-21 14:02 UTC, Philip Withnall 		none Details | Review
Add mapping from GIR's gsize to Vala's size_t (829 bytes, patch)
2010-07-21 14:03 UTC, Philip Withnall 		none Details | Review

Description Travis Reitter 2010-07-19 21:58:06 UTC 
This recent gobject-introspection commit:

http://git.gnome.org/browse/gobject-introspection/commit/?id=017727630d09a854b1c1a4767066fb675b139de9

Changes the format of element docs from:

<foo doc='bar'>...</foo>

to

<foo><doc>bar</doc>...</foo>

Vapigen doesn't cope well with unknown tags, so this pretty much breaks vapigen as a GIR parser. Eg:

TelepathyGLib-0.12.gir:20.7-20.38: error: unknown child element `doc' in `class'
TelepathyGLib-0.12.gir:20.7-20.38: error: expected end element of `class'
TelepathyGLib-0.12.gir:20.39-20.552: error: expected end element of `namespace'
TelepathyGLib-0.12.gir:20.553-20.558: error: expected end element of `repository'
Generation failed: 4 error(s), 0 warning(s)
Comment 1 Travis Reitter 2010-07-19 22:07:20 UTC 
It may be worthwhile to also make unknown elements issue warnings instead of errors, to avoid simple changes like this causing fatal errors.
Comment 2 Philip Withnall 2010-07-21 14:02:42 UTC 
Created attachment 166284 [details] [review]
Completely ignore <doc> tags in GIR files
Comment 3 Philip Withnall 2010-07-21 14:03:14 UTC 
Created attachment 166285 [details] [review]
Add mapping from GIR's gsize to Vala's size_t
Comment 4 Jürg Billeter 2010-07-21 15:28:22 UTC 
commit f00fcf2e72c251f44398bbe5e53db0a85ee82036
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Wed Jul 21 15:01:00 2010 +0100

    girparser: Add mapping from GIR's gsize to Vala's size_t

commit 7503681642ddf29f67401e3bd396264711513489
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Wed Jul 21 14:51:13 2010 +0100

    girparser: Completely ignore <doc> tags
Comment 5 Philip Withnall 2010-07-27 15:50:22 UTC 
*** Bug 619703 has been marked as a duplicate of this bug. ***