Created attachment 166169 [details] [review]
Check for TFP usage after actually setting the pixmap

Starting with clutter 1.4 clutter / cogl only knows whether TFP is in use after
setting the pixmap, so doing the check before setting the pixmap will just
lead to a wrong message.

https://bugzilla.gnome.org/show_bug.cgi?id=624571

See http://bugzilla.clutter-project.org/show_bug.cgi?id=2236 for reference.

Review of attachment 166169 [details] [review]:

Looks fine. (The whole warning is in dubious taste - it should likely only warn once or not at all.)

 - You might want to strip down to one bug reference in the commit message
 - A comment explaining that the clutter call only works after setting the pixmap would be a good idea.

(In reply to comment #3)
> Review of attachment 166169 [details] [review]:
> 
> Looks fine. (The whole warning is in dubious taste - it should likely only warn
> once or not at all.)

Yeah it is not like it should be printed out that often in real world scenarios,
but it it might be helpful to identify why things are "very slow" (in case we hit a driver bug or some other weirdness).

>  - You might want to strip down to one bug reference in the commit message
>  - A comment explaining that the clutter call only works after setting the
> pixmap would be a good idea.

OK.

Attachment 166169 [details] pushed as ce1ffa4 - Check for TFP usage after actually setting the pixmap