GNOME Bugzilla – Bug 623682
/query and /msg command are broken
Last modified: 2011-08-29 10:12:43 UTC
The /query command is currently broken in git master. To fix it we need API to request a channel that we're going to handle ourself which is: https://bugs.freedesktop.org/show_bug.cgi?id=13422
This affects /msg as well.
Actually what we really need is the "request and observe" case: https://bugs.freedesktop.org/show_bug.cgi?id=29457 The requested channel has to be dispatched to its handler first and then we can send the message.
Seems it will be for 3.0 as we don't have the needed pieces in tp-glib and MC yet.
This affects the /msg command as well.
*** Bug 629680 has been marked as a duplicate of this bug. ***
*** Bug 634141 has been marked as a duplicate of this bug. ***
Created attachment 181680 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/query-623682 libempathy-gtk/empathy-chat.c | 62 +++++++++++++++++++++++++---------------- 1 files changed, 38 insertions(+), 24 deletions(-)
Comment on attachment 181680 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/query-623682 Looks good to me. >+ TpTextChannel *text = (TpTextChannel *) channel; I'd do TP_TEXT_CHANNEL () since that checks channel really is a TpTextChannel. And you need to bump the tp-glib dependency. Feel free to commit directly with those changes.
(In reply to comment #8) > (From update of attachment 181680 [details] [review]) > Looks good to me. > > >+ TpTextChannel *text = (TpTextChannel *) channel; > > I'd do TP_TEXT_CHANNEL () since that checks channel really is a TpTextChannel. I checked it just the line before: + if (!EMP_STR_EMPTY (data->message) && TP_IS_TEXT_CHANNEL (channel)) { That's because we have to make sure that the channel actually implement Messages. > And you need to bump the tp-glib dependency. I already did it when I merged the room list branch: http://git.gnome.org/browse/empathy/commit/?id=c96c271f838ffa3911bd301b37b6c7aaffb2dfc2
Merged to master; no need to backport to 2.34. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Since there was a regression with this fix in the next patch can you also include support for "/join"?
(In reply to comment #11) > Since there was a regression with this fix in the next patch can you also > include support for "/join"? What do you mean? /join is implemented since a while. I you are experiencing issues with it please file another bug.
You are correct it is fixed. Sorry I just remembered the issue from awhile ago. Thank you and no problems now.