After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623520 - gtk+ 3 fails to build from outside git source tree
gtk+ 3 fails to build from outside git source tree
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 569778
 
 
Reported: 2010-07-04 11:56 UTC by Theppitak Karoonboonyanan
Modified: 2010-07-10 04:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Split the built sources from manual (3.84 KB, patch)
2010-07-04 12:09 UTC, Theppitak Karoonboonyanan 		none Details | Review
Remove the $(srcdir) suffix addition (2.06 KB, patch)
2010-07-04 14:24 UTC, Theppitak Karoonboonyanan 		none Details | Review

Description Theppitak Karoonboonyanan 2010-07-04 11:56:34 UTC 
Similar to Bug 617867 for gtk+/gdk-pixbuf 2.21.x, gtk+ 3 fails to build from outside source tree with the following error:

---8<---
Making all in .
make[4]: Entering directory `/home/thep/build/gnome_git/gtk+-3/gdk'
make[4]: *** No rule to make target `/home/thep/vcs/gnome_git/gtk+-3/gdk/gdkenumtypes.c', needed by `Gdk-3.0.gir'.  Stop.
make[4]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gdk'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gdk'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gdk'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thep/build/gnome_git/gtk+-3'
make: *** [all] Error 2
---8<---

And, after fixing this one, as will be described in a patch, another error is found under gtk/ subdir:

---8<---
make[4]: *** No rule to make target `/home/thep/vcs/gnome_git/gtk+-3/gtk/gtktypebuiltins.h', needed by `Gtk-3.0.gir'.  Stop.
make[4]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gtk'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gtk'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/thep/build/gnome_git/gtk+-3/gtk'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/thep/build/gnome_git/gtk+-3'
make: *** [all] Error 2
---8<---
Comment 1 Theppitak Karoonboonyanan 2010-07-04 12:09:15 UTC 
Created attachment 165218 [details] [review]
Split the built sources from manual

This patch splits the built sources from manual sources, and only adds srcdir prefix to the manual ones.

Note that it also fixes another build error caused by an attempt to link against system-installed libgdk-x11-3.0.so instead of the locally built one in $(top_builddir)/gdk/ (see also Bug 620868), so it can be tested.
Comment 2 Christian Persch 2010-07-04 12:36:12 UTC 
The split into srcdir and builddir sources shouldn't be necessary anymore now
that bug 616425 is fixed.
Comment 3 Theppitak Karoonboonyanan 2010-07-04 13:50:52 UTC 
(In reply to comment #2)
> The split into srcdir and builddir sources shouldn't be necessary anymore now
> that bug 616425 is fixed.

That's weird. The bug has been fixed for a month but I still saw this bug today.
Comment 4 Theppitak Karoonboonyanan 2010-07-04 14:24:50 UTC 
Created attachment 165222 [details] [review]
Remove the $(srcdir) suffix addition

I see. The bug is still there because of the $(addprefix ...) clauses. Remove them and $^ can work via VPATH.
Comment 5 Theppitak Karoonboonyanan 2010-07-10 04:20:47 UTC 
Thanks for committing the fix. Note, however, that the g-i dependency bump to 0.9.0 is not necessary. The new make rule is available since 0.6.14, which already met what required in previous configure.in.