After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623218 - oggdemux: Handle errors from _get_next_page in _do_seek.
oggdemux: Handle errors from _get_next_page in _do_seek.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.22
Other Windows
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-30 15:25 UTC by Philip Jägenstedt
Modified: 2010-06-30 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (902 bytes, patch)
2010-06-30 15:26 UTC, Philip Jägenstedt 		none Details | Review

Description Philip Jägenstedt 2010-06-30 15:25:26 UTC 
We found a crash here when using our custom source element. It's a bit peculiar in that there's no guarantee that data that has been successfully read once may not succeed the second time, as the browser cache may have been emptied in between.
Comment 1 Philip Jägenstedt 2010-06-30 15:26:17 UTC 
Created attachment 164971 [details] [review]
patch
Comment 2 Tim-Philipp Müller 2010-06-30 15:59:50 UTC 
Looks ok to me. Wim?
Comment 3 Wim Taymans 2010-06-30 16:08:53 UTC 
yep, looks good.
Comment 4 Tim-Philipp Müller 2010-06-30 16:50:08 UTC 
Pushed, thanks!

commit 3c06cabb0b185e4ebbee0de89e343509b1f20af3
Author: Fredrik Söderquist <fs@opera.com>
Date:   Thu Jun 24 16:55:57 2010 +0200

    oggdemux: Handle errors from _get_next_page in _do_seek.
    
    If the source element failed here, oggdemux would crash.
    
    Fixes #623218.