Created attachment 164573 [details] [review]
Remove GdkWindowObject public structure

This is a partial patch.

This code from tests/testwindows.c should still be ported:

static gboolean
window_has_impl (GdkWindow *window)
{
  GdkWindowObject *w;
  w = (GdkWindowObject *)window;
  return w->parent == NULL || w->parent->impl != w->impl;
}

Any idea about this?

Alex: Could you help with this last issue?

You need to add a 
gboolean gdk_window_has_native(GdkWindow *window)
and use that.

Created attachment 164852 [details] [review]
Implement gdk_window_has_native()

Created attachment 164856 [details] [review]
Remove GdkWindowObject public structure.v2

Remove GdkWindowObject public structure using the new gdk_window_has_native() function

(In reply to comment #4)
> Created an attachment (id=164852) [details] [review]
> Implement gdk_window_has_native()

Might be a good idea to mention that gdk_window_ensure_native() can be used if a native window is needed.

looks good to me.

Comment on attachment 164852 [details] [review]
Implement gdk_window_has_native()

committed with the christian comments.
commit df106318f8a62bb9bb4b1afe04a9b7f2919eb98d

Comment on attachment 164856 [details] [review]
Remove GdkWindowObject public structure.v2

commit 319d2bb4f1332e2e35d70a6acccb3b12b87dfd89

Comment on attachment 164852 [details] [review]
Implement gdk_window_has_native()

Also, committed in gtk-2-22 branch in commit  6de36e580ba8acec2fdfc35c17435851fcad06cc

This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks for the help / reviews!

> Also, committed in gtk-2-22 branch in commit 

I don't understand this part. Why are we removing things in 2.x ?!

(In reply to comment #12)
> > Also, committed in gtk-2-22 branch in commit 
> 
> I don't understand this part. Why are we removing things in 2.x ?!

I've only applied in gtk-2-22 the patch to add the accessor.