After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622658 - GTK_STOCK_FILE Stock Label
GTK_STOCK_FILE Stock Label
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-24 20:18 UTC by Ted Gould
Modified: 2010-08-25 04:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple patch to add the label. (1.43 KB, patch)
2010-06-24 20:20 UTC, Ted Gould 		committed Details | Review
Mention that GTK_STOCK_FILE only has a label since 3.0 (758 bytes, patch)
2010-07-23 14:15 UTC, Christian Dywan 		none Details | Review

Description Ted Gould 2010-06-24 20:18:46 UTC 
There is an icon, but not a translatable label for GTK_STOCK_FILE.  It seems like there should be so that it gets translated all in one place.  Similar to GTK_STOCK_EDIT.
Comment 1 Ted Gould 2010-06-24 20:20:22 UTC 
Created attachment 164548 [details] [review]
Simple patch to add the label.
Comment 2 Christian Dywan 2010-06-25 10:14:55 UTC 
I believe this is intentional. Stock items should not be used in the menubar.
Comment 3 Ted Gould 2010-06-25 13:29:48 UTC 
I can see not wanting people to use gtk_image_menu_item_new_from_stock() as that would put an icon in the menu bar as well.  But I think that doing a gtk_stock_item_lookup() to get the label and using that in gtk_menu_item_new() makes a bunch of sense so that there's only one "_File" string to translate.
Comment 4 Matthias Clasen 2010-07-10 05:28:45 UTC 
The reason it is like this is that STOCK_FILE was only added to have a stock icon for the file chooser. But I don't think there is anything fundamentally wrong with adding the label. Please go ahead.
Comment 5 Javier Jardón (IRC: jjardon) 2010-07-19 13:27:08 UTC 
Comment on attachment 164548 [details] [review]
Simple patch to add the label.

commit 6330ea9e43edd3025d3281f5779e6352eb7f2308
Comment 6 Javier Jardón (IRC: jjardon) 2010-07-19 13:27:18 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 7 Christian Dywan 2010-07-23 14:14:23 UTC 
I think this should be documented, otherwise it will lead to surprises.
Comment 8 Christian Dywan 2010-07-23 14:15:14 UTC 
Created attachment 166448 [details] [review]
Mention that GTK_STOCK_FILE only has a label since 3.0