GNOME Bugzilla – Bug 622473
Adding up the totals for all directories does not add up
Last modified: 2012-10-13 15:11:29 UTC
See the attached screenshot, baobab tells me 6.6GB is used on the disk but when you look at all the directories it only adds up to around 4.8GB. It turned out the remaining 1.8GB was located in another user's home but I found the totals not adding up very confusing http://img268.imageshack.us/f/screenshotfb.png/
Created attachment 225383 [details] [review] Show scan errors in the treeview using colors
This should help to avoid the confusion
Created attachment 225384 [details] [review] Show scan errors in the treeview using colors Ops.. committed to much
Review of attachment 225384 [details] [review]: ::: src/baobab-cellrenderers.vala @@ -26,1 +28,16 @@ - text = "%.1f %%".printf (value); + text = (state != Scanner.State.ERROR ? "%.1f %%".printf (value) : ""); + } + } ... 13 more ... instead of hardcoding orange, push an error class on the style context and then remove it after rendering and then set the error color in css
Created attachment 225385 [details] [review] Show scan errors in the treeview using colors I couln't figure out how to use CSS to make the font bold... but maybe we don't even need to make it bold.
Created attachment 225386 [details] [review] Add theming for baobab error states Corresponding patch for gnome-themes-standard
Both patches look good!
Comment on attachment 225385 [details] [review] Show scan errors in the treeview using colors Attachment 225385 [details] pushed as 5374f02 - Show scan errors in the treeview using colors