Should be a rather easy fix.

Created attachment 164398 [details] [review]
Fix the typo

After a night of hacking, here's the patch. Note that grepping Banshee in Hyena shows a lot of references left, so there might be some further work.

I don't think that's the right solution: this is a user-visible dialog. Ideally it should read "Banshee encountered ..." when used within Banshee and "F-Spot encountered ..." when used within F-Spot.

Adding Gabriel as CC.

Created attachment 165021 [details] [review]
Add a ApplicationName property to ApplicationContext.

This is used to display a proper name in the ExceptionDialog and
 can also be used to set the process name.

Review of attachment 165021 [details] [review]:

Better solution, but:

::: src/Hyena.Gui/Hyena.Gui.Dialogs/ExceptionDialog.cs
@@ -51,2 +51,4 @@
             Resizable = false;
-            Title = Catalog.GetString("Banshee Encountered a Fatal Error");
+            Title = string.Format("{0} {1}",
+                                  Hyena.ApplicationContext.ApplicationName,
+                                  Catalog.GetString("Encountered a Fatal Error"));

You can't assume that every language puts the application name first. This means you'll have to do something like:

String.Format (Catalog.GetString("{0} Encountered a Fatal Error"), ApplicationContext.ApplicationName)

Mind: String, not string.
Also mind: No Hyena prefix.
Third one: Probably best to add a translators comment here to explain what this string means (=> {0} is substituted by app name).

Example of a translators comment (from Banshee):

   // Translators: {0} is the name of a library, eg 'Music' or 'Podcasts'
   var label = new Label (String.Format (Catalog.GetString ("{0}:"), library.Name));

Created attachment 165023 [details] [review]
Add a ApplicationName property to ApplicationContext.

This is used to display a proper name in the ExceptionDialog and
 can also be used to set the process name.

Thanks for looking at this Ruben. 

Why should I use String and not string?

Review of attachment 165023 [details] [review]:

Looks good for me, will talk to Gabriel to get this committed. Thanks a lot!

Comment on attachment 165023 [details] [review]
Add a ApplicationName property to ApplicationContext.

I don't like the +        public static void TrySetProcessName ()
part of the patch, since "PDF Mod" isn't what I'd want the process name to be, but rather "pdfmod".  Plus the ApplicationName may be translated.

Maybe we should just remove "Banshee " from the string, leaving it "Encountered a Fatal Error"?

If you really think having the name in there is important, then change the property decl to "public static string ApplicationName { get; set; }" all one line, lower case string for declarations.

(In reply to comment #10)
> If you really think having the name in there is important, then change the
> property decl to "public static string ApplicationName { get; set; }" all one
> line, lower case string for declarations.

It's not that important for F-Spot, but it matters for Banshee. When streaming from the systray, Banshee occasionally runs into a fatal error and pops up that dialog. Without the name in there, I'd have no idea who caused it. Oh and the funny thing is that it keeps on playing.

So let's just drop the TrySetProcessName part of it :-)

Created attachment 165035 [details] [review]
Add a ApplicationName property to ApplicationContext.

This is used to display a proper name in the ExceptionDialog and
 can also be used to set the process name.

Created attachment 165038 [details] [review]
Add an ApplicationName property to ApplicationContext.

Review of attachment 165038 [details] [review]:

Committed, thanks

Created attachment 165381 [details] [review]
Set application name for exception dialog.

The last patch with an update of the linked hyena version should fix this.

Comment on attachment 165381 [details] [review]
Set application name for exception dialog.

Merged