After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621802 - Add a --no-sprocket-holes option
Add a --no-sprocket-holes option
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Thumbnailer
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-06-16 16:46 UTC by iain
Modified: 2011-02-26 01:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add --no-sprocket-holes option (2.73 KB, patch)
2010-06-16 16:46 UTC, iain 		none Details | Review
Patch (1.08 KB, patch)
2010-09-25 08:08 UTC, Ross Burton 		none Details | Review

Description iain 2010-06-16 16:46:14 UTC 
Created attachment 163848 [details] [review]
Add --no-sprocket-holes option

Attached is a patch that adds a --no-sprocket-holes option so thumbnails can be generated without the sprocket holes down the sides.
Comment 1 Bastien Nocera 2010-09-02 18:10:31 UTC 
Remind me what this was for.
Comment 2 Philip Withnall 2010-09-02 18:50:33 UTC 
I think it was so that the output of the thumbnailer could be used in scripts (processed further to produce something weird and wonderful), but I could be wrong.
Comment 3 iain 2010-09-07 21:30:15 UTC 
so that the totem thumbnailer can be used to just generic plain thumbnails of videos when --raw can't be used because --raw doesn't scale it so you'd use

totem-video-thumbnailer --size=256 --no-sprocket-holes file.avi

I guess the other way would be to make --raw work with --size
Comment 4 Ross Burton 2010-09-08 22:21:18 UTC 
The patch looks good to me.  Bastien, can this get merged?
Comment 5 Bastien Nocera 2010-09-08 22:42:35 UTC 
No, I'd rather make --raw work with --size.
Comment 6 Bastien Nocera 2010-09-09 12:17:18 UTC 
commit adc93d1a1046ac5e939bf6e0a29088476201435e
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Sep 9 13:14:22 2010 +0100

    Make it possible to use --raw along with --size
    
    So that you can save a thumbnail of a video at a particular
    size, with no borders, but still with resizing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621802
Comment 7 Ross Burton 2010-09-25 08:03:54 UTC 
This doesn't work as sprockets are always added in scale_pixbuf() if the size > 256.
Comment 8 Ross Burton 2010-09-25 08:08:54 UTC 
Created attachment 171079 [details] [review]
Patch
Comment 9 Bastien Nocera 2010-10-05 09:25:59 UTC 
Committed, after fixing the whitespace use.

commit 83a6792f80a8de73c3bb2dd13bc44e16a22039b7
Author: Ross Burton <ross@linux.intel.com>
Date:   Sat Sep 25 09:08:15 2010 +0100

    Check if large thumbnails need borders
    
    Otherwise large (>256) raw thumbnails got sprockets anyway.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621802
Comment 10 Ross Burton 2010-10-07 15:03:48 UTC 
--raw --size 512 is giving me 1000px+ wide thumbnails for HD videos.
Comment 11 Bastien Nocera 2011-02-26 01:42:54 UTC 
commit feeef30d80a298d99c6db34aff9657debb0ab725
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sat Feb 26 01:42:00 2011 +0000

    thumbnailer: Make --size XX --raw work
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621802