GNOME Bugzilla – Bug 620440
Combo-boxes loose focus
Last modified: 2010-06-15 17:47:37 UTC
After recent commit named "Merge the xi2-for-master branch" (SHA1 ID bd4609b14042a91646cd9057764eecfbc6faf42b) combo boxes stopped to work in the print dialog. They show up but I can not select anything. Similar thing happens when I click on gtk3-demo -> Color Selector -> Change the above color -> eyedropper.
Created attachment 163700 [details] [review] Make GTK+ device grabs take precedence over GTK+ grabs Fixes https://bugzilla.gnome.org/show_bug.cgi?id=620440 (Reported by Marek Kašík), where the print dialog modality would impair the pop-up window from getting events. Device GTK+ grabs gain in specificness.
Review of attachment 163700 [details] [review]: Ok, makes sense I guess. Sneaky way to introduce grab priorities :-) ::: gtk/gtkmain.c @@ -1476,3 @@ - * then we send the event to the original event widget. - * This is the key to implementing modality. - */ We probably want to keep this comment ?
(In reply to comment #2) > Review of attachment 163700 [details] [review]: > > Ok, makes sense I guess. Sneaky way to introduce grab priorities :-) It is :), all in all, modality is something collaborative UIs will have to handle carefully. > > ::: gtk/gtkmain.c > @@ -1476,3 @@ > - * then we send the event to the original event widget. > - * This is the key to implementing modality. > - */ > > We probably want to keep this comment ? Oh, indeed, just added this back and pushed.