GNOME Bugzilla – Bug 620439
"Join favorites" should deal better with connecting accounts
Last modified: 2010-06-03 12:53:55 UTC
- Have at least 2 accounts A and B (ideally one fast and one slow to connect) with favorites chatroom in both accounts - Set your presence to online - Once the first account A is connected hit F5 or the "Join favorite rooms" menu entyr - The rooms of A are joined but not the ones fo B which is confusing. Empathy should join B's rooms once it's connected. It should probably have some kind of timeout to not join favorites rooms after one hour if the account takes ages to connect.
Created attachment 162625 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/fav-room-620439 src/empathy-main-window.c | 110 ++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 104 insertions(+), 6 deletions(-)
Review of attachment 162625 [details] [review]: Looks good. One tiny change, but you can merge it once that's fixed. ::: src/empathy-main-window.c @@ +929,3 @@ + join_chatroom (ctx->chatroom, ctx->timestamp); + +disconnect: This is an obscure label name, because it gets called anyway. "finally" would be better.
Merged in 2.30 and master. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.