After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620105 - The location of the Close button on the Window Previews in Expose
The location of the Close button on the Window Previews in Expose
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 631248 651856 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-30 16:47 UTC by Ustun
Modified: 2011-06-07 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Make close button respect button_layout (2.06 KB, patch)
2011-06-07 11:47 UTC, Florian Müllner 		committed Details | Review

Description Ustun 2010-05-30 16:47:23 UTC 
The location of the Close button on the Window Previews in Expose should be specificable. Currently, it is on the right side of the window.

This causes inconsistencies if the Close button in windows are put on the left, as in OS X. (Like Ubuntu does)
Comment 1 Milan Bouchet-Valat 2010-05-30 21:04:54 UTC 
As I said on IRC, I think this could be done by checking Mutter's GConf settings about the side where the buttons are, plus the settings for current theme if applicable. But of course an Ubuntu user/developer would have to write the patch, since no other distro cares about this.

Or is the plan to ship the Shell with a specific theme? In that case, buttons could be assumed to be on the right, and that bug could not happen.
Comment 2 Florian Müllner 2010-10-03 19:36:00 UTC 
*** Bug 631248 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2011-06-04 22:59:31 UTC 
*** Bug 651856 has been marked as a duplicate of this bug. ***
Comment 4 Florian Müllner 2011-06-07 11:47:38 UTC 
Created attachment 189386 [details] [review]
workspace: Make close button respect button_layout

Make the close button in the overview follow the user preference
for the window button layout.
Comment 5 Dan Winship 2011-06-07 18:29:57 UTC 
Comment on attachment 189386 [details] [review]
workspace: Make close button respect button_layout

Testing this, I saw a close box get clipped by the left edge of the workspace area in one case. (With 5 windows open, although after moving windows around, I couldn't get the bug to come back.) Probably the layout rules have enough padding on the right side, but not the left?
Comment 6 Dan Winship 2011-06-07 18:34:00 UTC 
Comment on attachment 189386 [details] [review]
workspace: Make close button respect button_layout

Hm, no, it's just that the layout the first time you go into the overview is always bad, even with the normal arrangement
Comment 7 Florian Müllner 2011-06-07 18:55:31 UTC 
Attachment 189386 [details] pushed as ea1e5a5 - workspace: Make close button respect button_layout