After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619935 - [info] Additional output for git branches
[info] Additional output for git branches
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on: 618974
Blocks:
 
 
Reported: 2010-05-28 12:50 UTC by Dirk Wallenstein
Modified: 2010-06-08 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[info] Additional output for git branches (1.47 KB, patch)
2010-05-28 12:50 UTC, Dirk Wallenstein
needs-work Details | Review
[info] Display git specific branch and tag information (1.16 KB, patch)
2010-06-05 11:57 UTC, Dirk Wallenstein
none Details | Review

Description Dirk Wallenstein 2010-05-28 12:50:20 UTC
Most importantly, this will make the path to the sources available in
the info output. It will also display other branch attributes that might
be of interest to a user.
Comment 1 Dirk Wallenstein 2010-05-28 12:50:23 UTC
Created attachment 162214 [details] [review]
[info] Additional output for git branches
Comment 2 Craig Keogh 2010-06-05 09:21:57 UTC
Review of attachment 162214 [details] [review]:

Thank you for your patch. With your patch, jhbuild info gobject-introspection:

Name: gobject-introspection
Module Set: gnome-suites-3.0
Type: autogen
Install date: not installed
Git-Module: ssh://cskeogh@git.gnome.org/git/gobject-introspection
Checkoutroot: /home/oxyde/gnome2
Checkoutdir: None
Subdir: 
Sourcedir: /home/oxyde/gnome2/gobject-introspection
Checkoutmode: update
Branch: None
Tag: None
Tree-ID: 1c22f4e9fdb45ca08a9ef09e27ed3c4891a4388d
Requires: glib
Required-by: meta-gnome-desktop-suite, pygi, gir-repository, seed, gjs, mutter

Checkoutroot - Provides no useful information. All my modules are at /home/oxyde/gnome2
Checkoutdir: None - This isn't helpful.
Subdir: - No information? If no information is correct, don't display this line.
Is Checkoutmode of interest?
Branch: None - I'd expect to see 'master'.
Tag: None - If no tag, don't display.

jhbuild info intltool doesn't print path to the sources.

Also the documentation needs updating, see jhbuild/doc/C/jhbuild.xml
Comment 3 Dirk Wallenstein 2010-06-05 11:54:57 UTC
(In reply to comment #2)

> Checkoutroot - Provides no useful information. All my modules are at
> /home/oxyde/gnome2
> Checkoutdir: None - This isn't helpful.
> Subdir: - No information? If no information is correct, don't display this
> line.
All three are questionable, and finally result in the very useful source directory. I'll leave them out.
> Is Checkoutmode of interest?
No, I'll leave it out.
> Branch: None - I'd expect to see 'master'.
> Tag: None - If no tag, don't display.
> 
> jhbuild info intltool doesn't print path to the sources.
I've extracted the source directory display into bug 620648. With documentation for that part.
> Also the documentation needs updating, see jhbuild/doc/C/jhbuild.xml
This leaves the branch and tag information. I will add documentation for it when bug 618974 proceeds. I'll add a dependency to it.
Comment 4 Dirk Wallenstein 2010-06-05 11:57:38 UTC
Created attachment 162799 [details] [review]
[info] Display git specific branch and tag information
Comment 5 Frederic Peters 2010-06-08 08:51:48 UTC
commit 0a7f5b799bb2a0bd6f5573e9b99e8ae9bbb4a8b8
Author: Dirk Wallenstein <halsmit@t-online.de>
Date:   Sat Jun 5 13:28:01 2010 +0200

    [info] Display git specific branch and tag information (GNOME bug 619935)