After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619679 - [gstdvbsrc] gst_dvbsrc_tune() should poll interface instead of looping
[gstdvbsrc] gst_dvbsrc_tune() should poll interface instead of looping
Status: RESOLVED DUPLICATE of bug 641204
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: Zaheer Abbas Merali
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-25 22:31 UTC by Austin Lund
Modified: 2011-05-26 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to change to poll (10.03 KB, patch)
2010-05-25 22:31 UTC, Austin Lund 		needs-work Details | Review

Description Austin Lund 2010-05-25 22:31:39 UTC 
Created attachment 161981 [details] [review]
Patch to change to poll

Instead of just guessing the duration of tuning and sleeping for that long, the frontend should be polled to check for changes in the tuning status.

Attached a patch which does this.  It has a lot of whitespace changes as some for loops are removed.
Comment 1 Zaheer Abbas Merali 2010-06-02 07:43:13 UTC 
Ok I am looking at it. Thanks for the patch.
Comment 2 Austin Lund 2010-06-15 04:27:33 UTC 
The biggest problem with this patch is that it could loop forever if the status changes within the timeout (20 seconds) but the change is not to a signal locking state.  For example, you might change between getting the sync state and not having sync every few seconds which will reset the loop each time provided the state changes within the time-out (20 seconds).

The better option would probably be to have a hard time-out (say 60 seconds) and if sync isn't achieved by then, return FALSE.  However, this would complicate the poll call as the time-out would have to be calculated each time around the loop.
Comment 3 Mart Raudsepp 2011-03-21 21:13:27 UTC 
Bug 641204 seems to be further iteration of this work. Noting for reference
Comment 4 Sebastian Dröge (slomo) 2011-05-26 08:13:12 UTC 
Comment on attachment 161981 [details] [review]
Patch to change to poll

This should also use GstPoll if possible, let's track this further in bug #641204.
Comment 5 Sebastian Dröge (slomo) 2011-05-26 08:13:26 UTC 

*** This bug has been marked as a duplicate of bug 641204 ***