GNOME Bugzilla – Bug 619306
Indentation and justification is not always spoken.
Last modified: 2010-09-20 10:53:43 UTC
As Jose points out in: http://mail.gnome.org/archives/orca-list/2010-May/msg00591.html Indentation and justification isnt spoken when we give focus to application. --cut-- 1. Make sure that speak indentation and justification option is checked in the preference page of orca. 2. launch gedit with an empty file. 3. include two lines in the file with the following content, do not include the quotation: " line 1" " line 2" 4. Scroll in the file using up and down and observe that orca announces 4 spaces before line 1 and line 2. 5. Press ctrl+home. 6. Switch to another application pressing alt+tab. 7. Switch back to gedit pressing alt+tab. Orca should announce 4 spaces line 1 but instead it only announces line 1. --end cut-- I can reproduce this.
Created attachment 162511 [details] [review] Rev 1. Hi Jose, This patch seems to fix the problem for me. Before it will work, you need to apply the patch from bug #620320. Thank you for your feedback.
Oh look, see, great minds *do* think alike. <smile> This approach is what I was getting at in my comments to bug 620320. Therefore, could you instead do something along the following lines: 1. Move your new generator out of generator.py and put it in speech_generator.py. The string we want in braille is likely not going to coincide with the string we want to speak. 2. Take the code you currently have in 620320 and place it directly in speech_generator._generateTextIndentation() If you do the above, combined with the formatting string, I think you will have solved this bug and done so in a way which we can more easily expand upon later (tones instead of words, customizable braille). Thoughts?
By the way, this is something I'd like to see fixed for 2.31.3 if at all possible.
(In reply to comment #1) > Created an attachment (id=162511) [details] [review] > Rev 1. > > Hi Jose, > This patch seems to fix the problem for me. > Before it will work, you need to apply the patch from bug #620320. > > Thank you for your feedback. Hi Jon. I had problems to apply the patch, maybe I am doing something wrong. My steps: git branch teste git checkout teste git bz apply 620320 git bz apply 619306 I received the following messages: Patch format detection failed. Patch left in /tmp/Rev-1-H3ttk9.patch This is my first try with bz, perhaps I am doing something wrong. Thanks.
(In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=162511) [details] [review] [details] [review] > > Rev 1. > > > > Hi Jose, > > This patch seems to fix the problem for me. > > Before it will work, you need to apply the patch from bug #620320. > > > > Thank you for your feedback. > > Hi Jon. > I had problems to apply the patch, maybe I am doing something wrong. > My steps: > > git branch teste > git checkout teste > git bz apply 620320 > git bz apply 619306 > > I received the following messages: > Patch format detection failed. > Patch left in /tmp/Rev-1-H3ttk9.patch > > This is my first try with bz, perhaps I am doing something wrong. > Thanks. When I tried to apply manually I received the following: /tmp/Rev-1-H3ttk9.patch:39: trailing whitespace. warning: 1 line adds whitespace errors. I confirm that the patches fix the bug. Thanks.
Created attachment 162576 [details] [review] Rev 2. Fix for bgo#619306 - Indentation and justification is not always spoken. Joanie, doing as you suggested makes the patch for this smaller and cleaner :) Thanks! Jose, thanks for testing it out, sorry the previous attachment was attached by hand, rather than git bz, and thats why git bz didnt like it. This one also depends on the latest patch to bug #620320.
Works like a charm. Thanks.
Review of attachment 162576 [details] [review]: LGTM. Please commit (along with/after the fix for bug 620320, of course. :-) ) Thanks!
Commited to master. Thanks Joanie, Jose :)