After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619240 - fade in for top bar item background should match menu
fade in for top bar item background should match menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-20 21:51 UTC by William Jon McCann
Modified: 2010-06-08 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[panel] Use the same fade effects as menus (928 bytes, patch)
2010-06-01 15:08 UTC, Florian Müllner
none Details | Review
[panel] Use the same fade effects as menus (1.10 KB, patch)
2010-06-08 16:11 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2010-05-20 21:51:33 UTC
Currently the background of the user name item in the top bar fades in at a different rate than the menu.  It would look nicer if they were synchronized.
Comment 1 Florian Müllner 2010-05-20 22:17:47 UTC
The background is set by a CSS style change - currently, we don't have any way to animate those. There is some work in bug 619025 to implement style change transitions for hover, once we solve the general paint stuff satisfactorily, it should be pretty straightforward to expose the general functionality.
Comment 2 Florian Müllner 2010-06-01 15:08:47 UTC
Created attachment 162465 [details] [review]
[panel] Use the same fade effects as menus

Patch depends on bug 619025, which is still very much WIP ...
Comment 3 Florian Müllner 2010-06-08 16:11:45 UTC
Created attachment 163077 [details] [review]
[panel] Use the same fade effects as menus

Update patch to match the syntax of CSS transitions in master.
Comment 4 Owen Taylor 2010-06-08 16:43:01 UTC
Review of attachment 163077 [details] [review]:

The effect is pretty subtle, but the two fades seem to be in sync with this patch. (As long as you don't set Tweener.slowDownFactor)

Setting it once for .panel-button should be fine and you don't need to set it on the second class as well. OK, to commit if you remove the duplicate.
Comment 5 Florian Müllner 2010-06-08 17:36:08 UTC
Attachment 163077 [details] pushed as 7cc1cf3 - [panel] Use the same fade effects as menus

Fixed code duplication before pushing.