GNOME Bugzilla – Bug 619061
add search history and auto-completion
Last modified: 2010-05-21 07:29:13 UTC
Created attachment 161411 [details] [review] history+autocompletion This partly implements the request from https://bugzilla.gnome.org/show_bug.cgi?id=581343, that's why it's done as a separate report.
Comment on attachment 161411 [details] [review] history+autocompletion The patch looks good, but in testing I notice that after the 4th character in a lot of cases, it does the search even if I am still typing and have not experienced the 500ms timeout. This means that for "martyn", I see history of "marty" and "martyn". I think this needs to be fixed first, but then we can commit this.
Created attachment 161521 [details] [review] history+autocompletion here fixing the issue
Comment on attachment 161521 [details] [review] history+autocompletion Looks good to me, thanks for the patch!
For the future, could you make sure you commit message includes the bug number so we don't forget it for releases, thanks. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
It was ,ostly ok but... patch was not utf-8 compatible string.len should not be used as its the byte length - use utf8 length Also min length should use preference and also if its CJK entered be ignored (cause words in CJK are typically 1 character long)
1. Looking at vala GLib API, string.len is an 'alias' for g_utf8_strlen. 2. "min length should use preference" should be filed as a separate bug 3. I don't understand the note regarding CJK.