After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618993 - Fix various channel handling issues
Fix various channel handling issues
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 599158
 
 
Reported: 2010-05-18 15:30 UTC by Guillaume Desmottes
Modified: 2010-06-07 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/misc (7.14 KB, patch)
2010-05-18 15:32 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2010-05-18 15:30:10 UTC 
While working on approver support (bug #599158), I noticed 2 bugs in Empathy channels handling code:
- A race when receiving an incoming call
- We should join room where we have been invited to when handling the channel rather than when approving it
Comment 1 Guillaume Desmottes 2010-05-18 15:32:44 UTC 
Created attachment 161363 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/misc

 libempathy/empathy-call-factory.c |   48 +++++++++++++++++++++++++++++++----
 libempathy/empathy-tp-call.c      |    8 ++++++
 libempathy/empathy-tp-call.h      |    2 +
 libempathy/empathy-tp-chat.c      |   49 +++++++++++++++++++++++++++++++++++++
 libempathy/empathy-tp-chat.h      |    3 ++
 src/empathy-event-manager.c       |   15 +----------
 src/empathy.c                     |    7 +++++
 7 files changed, 112 insertions(+), 20 deletions(-)
Comment 2 Guillaume Desmottes 2010-06-07 11:03:30 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.