After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618982 - [wavparse] wrong closing segment when doing non-flushing seek
[wavparse] wrong closing segment when doing non-flushing seek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.22
Other All
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-18 13:41 UTC by Petre
Modified: 2010-06-29 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suggested patch (538 bytes, patch)
2010-05-18 13:41 UTC, Petre 		none Details | Review

Description Petre 2010-05-18 13:41:55 UTC 
Created attachment 161354 [details] [review]
suggested patch

While doing non-flushing seeks on a wavparse element, got gstreamer complaining that assertion 'start <= stop' is false.

Using gstreamer0.10.29, gst-plugins-base0.10.29, gst-plugins-good0.10.22

I am not sure what's going on in gstreamer, so this might be just my fault, but in gstwavparse.c, at line 970 (in gst_wavparse_perform_seek()), we have:

wav->close_segment = gst_event_new_new_segment (TRUE,
      wav->segment.rate, wav->segment.format,
      wav->segment.accum, wav->segment.last_stop, wav->segment.accum);

I think that the 4th parameter should be wav->segment.start. Changing this makes the error disapear. I've attached a tentative patch.
Comment 1 Mark Nauwelaerts 2010-06-22 13:45:26 UTC 
Patch was going in the right direction, following commit does a tiny bit more along those lines:

commit 0a2d9a22696bce63c1460ce09cc406e4983b315e
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Jun 22 15:22:44 2010 +0200

    wavparse: proper closing segment construction
    
    Fixes #618982.