After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618927 - Need to add Open TTS to available speech servers.
Need to add Open TTS to available speech servers.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.31.x
Other Linux
: Normal enhancement
: 2.32.0
Assigned To: Steve Holmes
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-17 20:47 UTC by Steve Holmes
Modified: 2010-09-20 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add openttsfactory.py and other files to support Open TTS server (18.11 KB, patch)
2010-05-18 04:02 UTC, Steve Holmes
committed Details | Review

Description Steve Holmes 2010-05-17 20:47:17 UTC
Since Speech Dispatcher has been forked and a new possible replacement for it has been developed, Orca should be able to support this new speech server.  The new server is cloned from Speech Dispatcher and is called Open TTS.  Open TTS has enjoyed greater development and code fixes lately than the older Speech Dispatcher.  The proposal with this enhancement is to add in support for Open TTS and leave Speech Dispatcher unchanged.
Comment 1 Steve Holmes 2010-05-17 20:53:26 UTC
I will take this one.  I have already coded the new openttsfactory.py and made related changes to Makefile.am and settings.py in my local tree.  I just need to unit test what I have before uploading a patch.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-05-17 21:00:44 UTC
It's yours. Much obliged!
Comment 3 Steve Holmes 2010-05-18 04:02:09 UTC
Created attachment 161312 [details] [review]
Patch to add openttsfactory.py and other files to support Open TTS server

As of May 17th, the new Open TTS package is still in a git development repository but this version of opentts will work with Orca after this patch is applied.  Testing included starting orca from the text console (orca -t), starting with no init files present as in starting gnome for the first time, and going into the Orca preferences dialogue under the Speech page.  Future changes to this enhancement would include a consolidation of the two files, speechdispatcherfactory.py and openttsfactory.py.
Comment 4 Steve Holmes 2010-05-26 07:17:45 UTC
Any chance this patch can be comitted soon?  I saw a message recently from Paul Hunt indicating he was successful at running both speech systems without any problems.
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-05-26 09:42:59 UTC
Since I haven't tested it.... 

Jon, what do you think? If you're OK with it, I say sure.
Comment 6 Mesar Hameed 2010-05-26 14:34:03 UTC
Sorry for not looking at this sooner.
Yes, looks fine to me.
diff -u dispatcherfactory.py opentts.py
made it a lot easier for me to see where the diffrences were. :)
Comment 7 Mesar Hameed 2010-05-26 17:01:09 UTC
Comment on attachment 161312 [details] [review]
Patch to add openttsfactory.py and other files to support Open TTS server

Steve, I've commited this to master.
Thanks for the work.

Please open a new bug for the merging of the two files.
Comment 8 Mesar Hameed 2010-08-04 17:19:09 UTC
From sd and opentts mailing lists, it looks like the dispute has been resolved and they are merging again.