After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618896 - lamemp3enc doesn't implement latency query
lamemp3enc doesn't implement latency query
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-17 17:04 UTC by Tristan Matthews
Modified: 2010-06-01 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implements latency query for lamemp3enc (922 bytes, patch)
2010-05-18 21:10 UTC, Tristan Matthews 		rejected Details | Review
implements latency query for lamemp3enc (2.25 KB, patch)
2010-05-20 15:31 UTC, Tristan Matthews 		none Details | Review
implements latency query for lamemp3enc (2.65 KB, patch)
2010-05-20 17:07 UTC, Tristan Matthews 		committed Details | Review

Description Tristan Matthews 2010-05-17 17:04:47 UTC 
The following launch line demonstrates how this negatively impacts the audio quality (we hear pops in the output):

GST_DEBUG=3 gst-launch -v audiotestsrc is-live=false freq=300 ! audio/x-raw-int, endianness=1234, signed=true, width=32, depth=32, rate=48000 ! audioconvert ! lamemp3enc ! mp3parse ! rtpmpapay ! gstrtpjitterbuffer ! rtpmpadepay ! mad ! audioconvert ! alsasink
Comment 1 Tristan Matthews 2010-05-18 21:10:01 UTC 
Created attachment 161382 [details] [review]
implements latency query for lamemp3enc
Comment 2 Sebastian Dröge (slomo) 2010-05-20 12:17:51 UTC 
Comment on attachment 161382 [details] [review]
implements latency query for lamemp3enc

Wrong patch, this is for speexenc.
Comment 3 Tristan Matthews 2010-05-20 15:31:32 UTC 
Created attachment 161558 [details] [review]
implements latency query for lamemp3enc

the patch i meant to submit
Comment 4 Tristan Matthews 2010-05-20 15:37:07 UTC 
The value of lame_get_framesize corresponds to the latency I measured in baudline.
Comment 5 Tristan Matthews 2010-05-20 17:07:32 UTC 
Created attachment 161573 [details] [review]
implements latency query for lamemp3enc

revised patch, besides implementing latency query, also check if encoder is valid and post latency message on bus.