GNOME Bugzilla – Bug 618790
The active descendant in OOo Writer 3.2's Templates and Documents dialog are not presented
Last modified: 2010-09-20 10:52:55 UTC
The problems are completely separate. One bug per problem. :-) +++ This bug was initially created as a clone of Bug #618774 +++ Hi, in Openoffice Writer, file->new->template and in rhythmbox in the tree-table on the left hand side, the focussed item is presented, when tabbing into the list. But when arrowing in the list, the new item is not presented. In OO Writer, the braille display is just blank, and in Rhythmbox it says "page grayed". Regards, Rudolf
Rudolf, on the OOo Writer bug, I'm not seeing it in OOo 3.3 dev. I did see that we were speaking "end of table" constantly in that list, so I just fixed that bug (committed to master). I'll try reverting to an earlier version of OOo. In the meantime, what version are you using, and any chance of a debug.out on this one? Thanks!
Hi Joannie, ok, I got myself a copy of OO3.3-dev (the initial report was for oo3.2). In OO3.3, the problem also exist partially: While the contents of the tree-table is spoken and brailled in file->new->templates, the iocns on the left hand side of the table are only spoken, but not brailled. Also, when selecting "my documents" on the left hand side, the list items on the right spoken and appear for a very short time on the braille display. Then, the display becoms blank, as well. For what exactly would you like to have a debug.out. OO3.2 and just arrowing through the lsit? Regards, Rudolf
Thanks Rudolf. I can confirm the braille issue with the items/icons on the left. (New Document, etc.). So I'll tackle that next. Yeah, on the 3.2 debug.out, arrowing through the list would be helpful. Thanks!
Probably some more appearances of the same issue: tools->options (tree on left hand side) Tools->mailmerge wizard (dito) Debug.out for 3.2 will follow.
Created attachment 161176 [details] debug.out. We start already in the list and press down sa few times
Hi Joannie, the patch you made for bug 618800 also solved all the issues in the tools-menu mentioned two comments above in oo3.2. The problem in file-new-templates still exists. Regards, Rudolf
Yeah, this looks like it's an OOo bug. We present the item in response to the object:active-descendant-changed event. Here's an example of mine: OBJECT EVENT: object:active-descendant-changed detail=(2,0,[table cell | Drawing]) Here's what I see in yours: OBJECT EVENT: object:active-descendant-changed detail=(0,0,[table cell | ]) So my event.any_data has a named item ('Drawing') and yours does not. Bah. The question that remains is: Can we get at the information some other way? (i.e. 3.3 is different/better than 3.2) Or, not? (i.e. 3.3 fixes something broken in 3.2) And to answer that question, I need to install OOo 3.2. (I was hoping it was merely a case of speech being interrupted too fast, which sometimes happens with object:active-descendant-changed events.)
Created attachment 161185 [details] [review] tentative fix So the problem was more interesting that I suggested earlier. We're comparing two objects and those two objects are passing the isSameObject() test due to the fact that they have the same name (which is empty) and they have the same index in parent (which is -1 which is an OOo bug that they apparently fixed in OOo 3.3). The attached hacks very, very specifically around their bug. Seems a shame to have to do this, but it does seem to solve the problem in OOo 3.2. I'm going to regression test this prior to committing.
Comment on attachment 161185 [details] [review] tentative fix Passed the regression tests for OOo Writer 3.3 in OpenSolaris and OOo Writer 3.2 in Ubuntu. Therefore, I've committed this patch to master.
Created attachment 161190 [details] [review] tentative fix - gnome-2-30 branch Because of various refactors, patches are no longer compatible between the gnome-2-30 branch and master. The attached seems to fix this bug for the gnome-2-30 branch. I'll regression test it now.
The patch for the 2-30 branch passed the regression tests in Ubuntu with OOo Writer 3.2. Therefore I've committed it as well. Closing as FIXED. Bring on the next issue, Rudolf <huge grin>. (All joking aside, thank you so much for all the reports and testing. I think we squashed some decent bugs today.)