After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618768 - Taglib# only writes in place
Taglib# only writes in place
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Metadata
GIT
Other Linux
: Normal normal
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: f-spot-taglib
 
 
Reported: 2010-05-16 08:58 UTC by Ruben Vermeersch
Modified: 2010-06-15 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ruben Vermeersch 2010-05-16 08:58:27 UTC 
Currently TagLib.File always overwrites the original file on writing. We need something safer, which writes to a temp file and only overwrites the original on success.
Comment 1 Ruben Vermeersch 2010-05-17 10:22:17 UTC 
The fix to this is probably to introduce a Save (IFileAbstraction abstraction) that will be used for saving.

Save () would then simply become a method that reuses this.file_abstraction.

Things to notice: we should probably only implement this for photos (for now), to keep the delta with upstream Taglib# low. We should also switch all the photo unit tests to use the new Save, to make sure the code path is tested for all file types.
Comment 2 Ruben Vermeersch 2010-06-15 19:16:16 UTC 
Now handled in the file abstraction.