After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618597 - totem crashes with BadMatch when gtk+ is in rgba mode
totem crashes with BadMatch when gtk+ is in rgba mode
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-05-14 08:35 UTC by Cody Russell
Modified: 2010-05-14 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (907 bytes, patch)
2010-05-14 08:35 UTC, Cody Russell 		none Details | Review
Updated patch (1017 bytes, patch)
2010-05-14 10:29 UTC, Cody Russell 		none Details | Review

Description Cody Russell 2010-05-14 08:35:58 UTC 
Created attachment 161029 [details] [review]
Proposed patch

I've been experimenting with changing gtk+ to support rgba colormap by default, and it causes totem to crash with a BadMatch error.

We're planning to do this for gtk+ 3.0, so we need to fix totem.  I'm attaching a patch that sets BaconVideoWidget's colormap to the system colormap.  This fixes the problem when gtk+ is in RGBA mode, and it also has no effect on totem when it's running on a current gtk+.
Comment 1 Bastien Nocera 2010-05-14 10:06:34 UTC 
Right fix, but wrong place.

That should be done in _realize() instead, as the video widget can also work without a connection to the DISPLAY.
Comment 2 Cody Russell 2010-05-14 10:29:54 UTC 
Created attachment 161035 [details] [review]
Updated patch

Updated patch.
Comment 3 Cody Russell 2010-05-14 10:42:35 UTC 
Pushed to master e8930fc