After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618565 - gstreamermm-0.10.7 fails to build with gcc 4.5
gstreamermm-0.10.7 fails to build with gcc 4.5
Status: RESOLVED FIXED
Product: gstreamermm
Classification: Bindings
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2010-05-13 19:18 UTC by Kacper Kowalik
Modified: 2011-01-16 23:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixing build with gcc 4.5 (7.17 KB, patch)
2010-05-13 19:18 UTC, Kacper Kowalik 		none Details | Review

Description Kacper Kowalik 2010-05-13 19:18:14 UTC 
Created attachment 160997 [details] [review]
fixing build with gcc 4.5

Direct calls of class' constructors are no longer allowed by gcc-4.5. As a result gstreamermm fails to build with lates gcc.

Downstream bug report: http://bugs.gentoo.org/show_bug.cgi?id=319375

Build log: please see downstream bug.

Please note that attached patch is backward compatible, i.e. works with gcc < 4.5

Best regards,
Kacper Kowalik
Comment 1 Daniel Elstner 2010-05-30 20:48:35 UTC 
Thanks for your bug report and patch.  You are right, the syntax used for object construction is incorrect and needs to be fixed.  Unfortunately, your patch changes files that are automatically generated during the maintainer mode build.

I have now made the corresponding change to the input files of the code generator:

commit fba7d3803a0af4b9b334c4c5d1b7d65bece09df2
Author: Daniel Elstner <danielk@openismus.com>
Date:   Sun May 30 22:40:25 2010 +0200

    Correct wrong syntax for object construction
    
    * tools/m4/convert_gst.m4 (GstIterator): Change conversions to use
    the correct C++ syntax for constructing objects; Iterator() instead
    of Iterator::Iterator().  The latter fails with GCC 4.5.  Reported
    by  Kacper Kowalik, GNOME bug #618565.
    * gstreamer/src/format.ccg (iterate_format_definitions): As above.

I hope I caught them all, and gstreamermm now builds fine with GCC 4.5.  If not, please reopen the bug.
Comment 2 José Alburquerque 2010-05-30 21:21:15 UTC 
Thanks for fixing this Daniel.  I don't know how, but I did not get this bug e-mailed to me so I didn't notice it.