GNOME Bugzilla – Bug 618476
Add UIManager and ActionGroup overrides
Last modified: 2010-05-19 20:07:47 UTC
ActionGroup overrides allow for passing tuples of arguments instead of creating GtkAction objects (objects are created in the override) UIManager override allows loading a UI definition from a python string without having to pass in the length of the string.
Created attachment 160922 [details] [review] [PATCH] add GtkUIManager and GtkActionGroup overrides gi/overrides/Gtk.py | 163 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 162 insertions(+), 1 deletions(-)
Review of attachment 160922 [details] [review]: Looks great! These are easily testable, should we require tests for all overrides?
Review of attachment 160922 [details] [review]: I agree with Johan, I would really like to see tests for the overrides. J5, would you mind giving that a stab? If it turns out to be a PITA we can skip it but I like Johan's idea of always requiring tests (assuming thats not an unreasonable burden).
Review of attachment 160922 [details] [review]: p.s. I love the detail in the comments.
Review of attachment 160922 [details] [review]: I will write the tests. The comments come directly from PyGTK so thank Johan or whoever git blame tells you is the author ;)
Pushed with tests along with a little fixup to join groups of radio actions with the new binding friendly API gtk_radio_action_join_group I just checked in[1] We only use it if it is present. Matthias said he could get it into GTK+ 2.21. [1] https://bugzilla.gnome.org/show_bug.cgi?id=618571