After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617660 - Improving iso-4217-currencies (part 1)
Improving iso-4217-currencies (part 1)
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Engine
git-master
Other All
: Normal enhancement
: ---
Assigned To: Derek Atkins
Derek Atkins
: 617109 (view as bug list)
Depends on:
Blocks: 118391
 
 
Reported: 2010-05-04 15:37 UTC by Frank H. Ellenberger
Modified: 2018-06-29 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improving-iso-4217-currencies.patch (35.67 KB, patch)
2010-05-04 15:37 UTC, Frank H. Ellenberger 		accepted-commit_now Details | Review
Improving-iso-4217-currencies.patch (36.92 KB, patch)
2010-05-05 17:29 UTC, Frank H. Ellenberger 		committed Details | Review

Description Frank H. Ellenberger 2010-05-04 15:37:10 UTC 
Created attachment 160270 [details] [review]
Improving-iso-4217-currencies.patch

Starting with https://lists.gnucash.org/pipermail/gnucash-devel/2009-October/026558.html was some discussion of the iso-4217-currencies.

Because further improvements of bug 118391 could produce heavyly to resolve conflicts with this, here is the current state of my work:
1. improve the header of fieldnames with annotations
2. sort by ISO code, because
   a. easier for non english people
   b. most tables in the internet have this sort order.
      So maintainance becomes easier.
3. inserting a Column local_symbol, because some people like to use it,  
   e.g. https://bugzilla.gnome.org/show_bug.cgi?id=492417#c3
   But probably there is a better way to get this informations.
4. Review List:
   a. adding: CDF, GHS, ...
   b. outdated: AON->AOR->AOA, GWP->XOF, ...
   c. Typos like "fening".
   d. Alway use singular instead of a mixture.
5. add comments:
   a. outdated currencies prepared as shown in the header.
   b. for abbreviations.
Comment 1 Frank H. Ellenberger 2010-05-05 10:12:56 UTC 
*** Bug 617109 has been marked as a duplicate of this bug. ***
Comment 2 Frank H. Ellenberger 2010-05-05 17:29:54 UTC 
Created attachment 160362 [details] [review]
Improving-iso-4217-currencies.patch

Oops, it seems, in my last commit before creating the patch, I updated the comment, but not the file, so here is the complete patch.
Comment 3 Christian Stimming 2010-05-06 08:33:57 UTC 
Comment on attachment 160362 [details] [review]
Improving-iso-4217-currencies.patch

Thanks!
Comment 4 John Ralls 2018-06-29 22:38:45 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=617660. Please update any external references or bookmarks.