After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617312 - Move documentation to inline comments: GtkDialog
Move documentation to inline comments: GtkDialog
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-04-30 19:06 UTC by Garrett Regier
Modified: 2011-01-04 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move documentation to inline comments: GtkDialog (20.28 KB, patch)
2010-04-30 19:06 UTC, Garrett Regier
needs-work Details | Review

Description Garrett Regier 2010-04-30 19:06:26 UTC
Created attachment 159994 [details] [review]
Move documentation to inline comments: GtkDialog

Move documentation to inline comments for GtkDialog
Comment 1 Javier Jardón (IRC: jjardon) 2010-10-02 23:46:24 UTC
Review of attachment 159994 [details] [review]:

Looks good, only some minor comments

::: gtk/gtkdialog.c
@@ +79,3 @@
+ * gtk_dialog_add_button(), gtk_dialog_add_buttons(), or
+ * gtk_dialog_add_action_widget(), clicking the button will emit a signal called
+ * "response" with a response ID that you specified. GTK+ will never assign a

Use #GtkDialog::response here

@@ +83,3 @@
+ * convenience, you can use the response IDs in the #GtkResponseType enumeration
+ * (these all have values less than zero). If a dialog receives a delete event,
+ * the "response" signal will be emitted with a response ID of #GTK_RESPONSE_DELETE_EVENT.

#GtkDialog::response

@@ +94,3 @@
+ * dialog contents manually if you had more than a simple message in the dialog.
+ * <example>
+ * <title>Simple <structname>GtkDialog</structname> usage.</title>

Use #GtkDialog here

@@ +101,3 @@
+ * void quick_message (gchar &ast;message) {
+ *
+ *    GtkWidget &ast;dialog, &ast;label, &ast;content_area;

You can use GtkWidget *dialog, *label, *content_area; here

@@ +132,3 @@
+ * <refsect2 id="GtkDialog-BUILDER-UI"><title>GtkDialog as GtkBuildable</title>
+ * <para>
+ * The GtkDialog implementation of the GtkBuildable interface exposes the

Use #GtkBuildable here