Created attachment 159695 [details] [review]
[panel] Fix allocation positioning for boxes

This change doesn't actually affect anything visibly, but
using the absolute coordinates of our allocation box in allocate()
is wrong; we should be positioning our children at 0,0 and using
width/height as a reference.

Created attachment 159696 [details] [review]
[panel] Remove hardcoded uses of PANEL_HEIGHT

It's cleaner to just y_fill.

Created attachment 159697 [details] [review]
[panel] Remove vertical padding for panel-button

This fixes the status menu requesting 27 pixels, which causes
the slicer for the icon to overdraw.

*** Bug 612974 has been marked as a duplicate of this bug. ***

Comment on attachment 159696 [details] [review]
[panel] Remove hardcoded uses of PANEL_HEIGHT

i *think* this one is correct, but see next review

Comment on attachment 159697 [details] [review]
[panel] Remove vertical padding for panel-button

this fixes the current-app indicator, but it makes the "Activities" button one pixel too short (so that there's a black line between the bottom of the highlighted button and the top of the dash), and the clock is even worse. Looking carefully, it seems like the clock is actually broken even without the patch; it doesn't extend all the way to the top of the panel. This patch seems to center it without fixing its height, so it now doesn't reach either the top or bottom edge.

Comment on attachment 159695 [details] [review]
[panel] Fix allocation positioning for boxes

Attachment 159695 [details] pushed as 3715109 - [panel] Fix allocation positioning for boxes

Comment on attachment 159696 [details] [review]
[panel] Remove hardcoded uses of PANEL_HEIGHT

Attachment 159696 [details] pushed as 704354b - [panel] Remove hardcoded uses of PANEL_HEIGHT

Attachment 159697 [details] pushed as 0513297 - [panel] Remove vertical padding for panel-button