After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616730 - user-switch-applet build failure: missing -I for dbus-glib
user-switch-applet build failure: missing -I for dbus-glib
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.28.x
Other Mac OS
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-24 19:52 UTC by Daniel Macks
Modified: 2010-06-17 00:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Macks 2010-04-24 19:52:00 UTC
Building gdm-2.28.2 on OS X 10.4 fails:

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../gui/simple-greeter -DPREFIX=\""/sw"\" -DLIBDIR=\""/sw/lib"\" -DDATADIR=\""/sw/share"\" -DSYSCONFDIR=\""/sw/etc"\" -DLIBLOCALEDIR=\""/sw/lib/locale"\" -DGNOMELOCALEDIR=\""/sw/share/locale"\" -DGLADEDIR=\""/sw/share/gdm"\" -DLIBEXECDIR=\""/sw/lib/gdm"\" -DSBINDIR=\""/sw/sbin"\" -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/lib/fontconfig2/include -I/sw/include/gtk-2.0 -I/sw/lib/gtk-2.0/include -I/sw/include/atk-1.0 -I/sw/include/cairo -I/sw/include/pango-1.0 -I/sw/include/pixman-1 -I/sw/include/freetype2 -I/sw/include -I/usr/X11R6/include -I/usr/X11/include -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/lib/fontconfig2/include -I/sw/include/gtk-2.0 -I/sw/lib/gtk-2.0/include -I/sw/include/atk-1.0 -I/sw/include/cairo -I/sw/include/pango-1.0 -I/sw/include/pixman-1 -I/sw/include/freetype2 -I/sw/include -I/sw/include/panel-2.0 -I/sw/include/gconf/2 -I/sw/include/libbonoboui-2.0 -I/sw/include/libbonobo-2.0 -I/sw/include/libgnomecanvas-2.0 -I/sw/include/libgnome-2.0 -I/sw/include/orbit-2.0 -I/sw/include/bonobo-activation-2.0 -I/sw/include/libart-2.0 -I/sw/include/libglade-2.0 -I/sw/include/libxml2 -I/usr/X11R6/include -I/usr/X11/include -DORBIT2=1  -I/sw/include  -Wall         -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes         -Wnested-externs -Wpointer-arith         -Wcast-align -Wsign-compare -Wp,-D_FORTIFY_SOURCE=2         -g -O2 -Wno-strict-aliasing -Wno-sign-compare -MT applet.o -MD -MP -MF .deps/applet.Tpo -c -o applet.o applet.c
applet.c:35:28: error: dbus/dbus-glib.h: No such file or directory
applet.c: In function 'fill_applet':
applet.c:1393: error: 'DBusGConnection' undeclared (first use in this function)
applet.c:1393: error: (Each undeclared identifier is reported only once
applet.c:1393: error: for each function it appears in.)
applet.c:1393: error: 'bus' undeclared (first use in this function)
applet.c:1519: warning: implicit declaration of function 'dbus_g_bus_get'
applet.c:1519: warning: nested extern declaration of 'dbus_g_bus_get'
applet.c:1519: error: 'DBUS_BUS_SESSION' undeclared (first use in this function)
make: *** [applet.o] Error 1



I have dbus-glib installed, but the -I for it is not passed. Looks like a bug in configure.ac:

>PKG_CHECK_MODULES(APPLET,
>        gtk+-2.0 >= $GTK_REQUIRED_VERSION
>        libpanelapplet-2.0 >= $GNOME_PANEL_REQUIRED_VERSION
>        libglade-2.0 >= $LIBGLADE_REQUIRED_VERSION)

should also check (and therefore automatically detect and propagate flags) for dbus-glib-1 there since the applet uses dbus-glib directly.
Comment 1 William Jon McCann 2010-06-17 00:26:51 UTC
commit e2476eaa2ed3a639693c1c438935765f63f27e71
Author: William Jon McCann <jmccann@redhat.com>
Date:   Wed Jun 16 20:25:59 2010 -0400

    Add dbus-glib to applet deps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=616730