After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616409 - [videomixer] AYUV blending broken
[videomixer] AYUV blending broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-21 16:00 UTC by Sebastian Dröge (slomo)
Modified: 2010-04-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videomixer: Fix AYUV checker/color filling (968 bytes, patch)
2010-04-21 17:55 UTC, Sebastian Dröge (slomo) 		committed Details | Review
videomixer: Fix byte order for MMX ARGB/AYUV color filling (1.13 KB, patch)
2010-04-22 11:31 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2010-04-21 16:00:19 UTC 
Hi,
see 

gst-launch-0.10 -v videotestsrc ! "video/x-raw-yuv,format=(fourcc)AYUV,width=640,height=480" ! videomixer name=mixer sink_1::alpha=0.5 background=black ! ffmpegcolorspace ! ximagesink    videotestsrc pattern=snow ! mixer.

and

gst-launch-0.10 -v videotestsrc ! "video/x-raw-yuv,format=(fourcc)AYUV,width=640,height=480" ! videomixer name=mixer sink_1::alpha=0.0 background=black ! ffmpegcolorspace ! ximagesink    videotestsrc pattern=snow ! mixer.

I've a patch for the latter and I'm working on a patch for the former atm...
Comment 1 Sebastian Dröge (slomo) 2010-04-21 17:55:43 UTC 
Created attachment 159272 [details] [review]
videomixer: Fix AYUV checker/color filling
Comment 2 Sebastian Dröge (slomo) 2010-04-21 17:56:32 UTC 
(In reply to comment #1)
> Created an attachment (id=159272) [details] [review]
> videomixer: Fix AYUV checker/color filling

This fixes the second, the first is a bug somewhere in the MMX version of the AYUV blending. At some point it worked though... I'll bisect tomorrow :(
Comment 3 Sebastian Dröge (slomo) 2010-04-22 11:31:30 UTC 
Created attachment 159323 [details] [review]
videomixer: Fix byte order for MMX ARGB/AYUV color filling

Fixes bug #616409.
Comment 4 Sebastian Dröge (slomo) 2010-04-22 11:32:03 UTC 
Ok, these two patches fix all issues (I hope).
Comment 5 Tim-Philipp Müller 2010-04-22 11:48:17 UTC 
Works for me too, please push these (one day we might want to also add a unit test that checks a strategically chosen pixel for blackness and/or desired colour...)
Comment 6 Sebastian Dröge (slomo) 2010-04-22 11:59:27 UTC 
commit 5a530b19e84b2e233220970f7e35e32218393ad0
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Apr 22 13:30:55 2010 +0200

    videomixer: Fix byte order for MMX ARGB/AYUV color filling
    
    Fixes bug #616409.

commit a27856e6b8becfe64e9e043937afb99840179bd6
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Apr 21 17:53:49 2010 +0200

    videomixer: Fix AYUV checker/color filling