After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616309 - gsettings-schema-convert should output gettext-domain by default
gsettings-schema-convert should output gettext-domain by default
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gsettings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-20 16:23 UTC by Bastien Nocera
Modified: 2010-07-02 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add gettext-domain if needed when converting from gconf (3.20 KB, patch)
2010-04-20 18:27 UTC, Vincent Untz 		none Details | Review

Description Bastien Nocera 2010-04-20 16:23:48 UTC 
It currently outputs the minimum amount of data. Having a "gettext-domain=FIXME" and a note in the migration guide about what to do would be nice.
Comment 1 Vincent Untz 2010-04-20 17:47:27 UTC 
This is only needed in case where you have a localized default value. Indeed, we should have a gettext-domain attribute in this case, and we can add an option so that the caller can set it.

Will fix it.
Comment 2 Vincent Untz 2010-04-20 18:27:44 UTC 
Created attachment 159185 [details] [review]
Add gettext-domain if needed when converting from gconf
Comment 3 Matthias Clasen 2010-04-20 23:36:16 UTC 
You also want a gettext domain if there are summary or description element, I think.
Comment 4 Matthias Clasen 2010-04-21 02:58:06 UTC 
Committed your patch, Vincent. Leaving this open to consider adding gettext-domain in more situations, I think we always want to add it if it is given on the commandline.
Comment 5 Vincent Untz 2010-07-02 17:31:23 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.