GNOME Bugzilla – Bug 616078
mpegvideoparse: Export profile and level in caps
Last modified: 2010-05-28 11:55:05 UTC
Attaching a patch which extracts the profile and level from the sequence extension header for MPEG2 streams and exports them in stream caps.
Created attachment 159001 [details] [review] mpegvideoparse: Export profile and level in caps This exports profile and level in caps for MPEG 2 streams.
commit bf586d796692d0e2be5b6e601cce8d0c7346695d Author: Arun Raghavan <arun.raghavan@collabora.co.uk> Date: Sun Apr 18 14:51:35 2010 +0530 mpegvideoparse: Export profile and level in caps This exports profile and level in caps for MPEG 2 streams. https://bugzilla.gnome.org/show_bug.cgi?id=616078
Comment on attachment 159001 [details] [review] mpegvideoparse: Export profile and level in caps >+ const gchar *profiles[] = { "HP", "Spatial", "SNR", "MP", "SP" }; >+ const gchar *levels[] = { "HL", "H-14", "ML", "LL" }; Maybe it's just me, but I don't think these strings are particularly nice (eg. profile=HP vs. profile=high, or profile=MP vs. profile=main, or level=HL vs. level=high). And why is it H-14 and not H-14L? (apologies for the bikeshedding)
I took the convention used in the spec and the Internet (Wikipedia and other sites), since I figured this would be more intuitive to anyone who is interested in this information.
Created attachment 161652 [details] [review] mpegvideoparse: change profile and level strings to something nicer-looking Alternative suggestion for profile/level names: - const gchar *profiles[] = { "HP", "Spatial", "SNR", "MP", "SP" }; + const gchar *profiles[] = { "high", "spatial", "snr", "main", "simple" }; - const gchar *levels[] = { "HL", "H-14", "ML", "LL" }; + const gchar *levels[] = { "high", "high-1440", "main", "low" }; - profile = "422P"; + profile = "4:2:2"; - profile = "MVP"; + profile = "multiview";
Comment on attachment 161652 [details] [review] mpegvideoparse: change profile and level strings to something nicer-looking I've committed this now, since Arun also agreed that this makes things look more consistent.